cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Medical Rework Phase 1 - Chemical Changes

Open Nihisohel opened this issue 8 months ago • 16 comments

About the pull request

Adds a chemical delivery spectrum for chemicals, ensuring that without using the proper delivery methods, lower potencies or even dangerous effects are delivered to the player as a penalty Autoinjectors are also given differing modes of injection to favor its use over pills

Explain why it's good for the game

Being able to swig a cup of your favorite healing chemicals in one gulp without penalty is not a good gameplay system It is an incredibly gamified use of the legacy chemical system which modern CM is attempting to move away from.

This PR will add a chemical delivery method spectrum system a bit similar to how TG has it, but a bit more nuanced than that

These delivery methods are: Controlled Ingestion : Pill ingestions Ingestions : Food/drink consumption Inhalation : Smoke and gasses

Touch : Self-explanatory

Absorption : Through the skin absorption (think lotion) or intramuscular injection Injection : Subcutaneous or Intravenous injection Implantation : Deep, or steady forms of injections (IV bags would reflect this form of method)

Each chemical has a preferred and undesired delivery method, and both can have multiple If the preferred is met, the potency of the chemical is not reduced If the preferred is not met, but is not an undesired delivery method, it will check how many steps away from the nearest preferred method and apply a penalty as follows

If the preferred method is Ingestion, but the delivery method is Controlled Ingestion: One step away from preferred delivery - Lesser effect, where the chemical potency is halved Two steps away - No effect Three or more steps away - Apply overdose effects (If the improper delivery is already overdosed, it will upgrade to a critical overdose)

If the undesired delivery is met (Example, Bicaridine undesired delivery is ingestion, and the delivery method is ingestion), it will similarly have the same effect as being three steps away from the spectrum, resulting in an overdose

In essence, this PR will make an attempt to circumvent unga ingestion through flasks, but not through medical mixes through the reagent pouches which utilize the INJECTION method, ensuring that medics aren't harmed too much by this change

To further incentivize the use of actual medical items, Autoinjectors are now rebalanced with two differing modes: Precise - Which allows you to use the injector while it is in your active hand, while also on the move Fast - Which allows you to use the injector instantaneously, at a cost of lower chemical potency due to its ABSORPTION delivery method (assuming the delivery method does not prefer absorption)

Testing Photographs and Procedure

It works, will need a TM image

image

Changelog

:cl: add: Chemicals now have their own preferred and undesired delivery methods, ensuring proper medical application while still retaining your favorite chemical mixes balance: Autoinjectors have two differing modes for use: Precise and Fast balance: Autoinjectors can now be used while on the move with Precision mode, with a movement speed malus until injected balance: Autoinjectors can also be injected instantaneously with Fast mode, but with lower chemical potency as a result balance: Hyposprays need the proper skill clearance to be used fix: Syringes now update their inhands properly fix: Syringes now properly uses its delay when the target is using a suit fix: ...and fixes a few other bugs present in syringe.dm, definitely not all of it fix: Cigarettes can now properly deliver into your bloodstream, with the proper delivery method, of course code: About every chemical delivery method is no longer either INGESTION or TOUCH, utilizing the proper delivery method for its type in the chemical delivery spectrum code: Reorganizes a few chemicals into its own files and better repaths refactor: Deletes robodropper.dm and makes the industrial dropper a child of the dropper /:cl:

Nihisohel avatar Apr 05 '25 17:04 Nihisohel

I'm curious on how it's gonna be implemented as there is no special chemistry reaction called: "unga juice" it's just many different medicines put into a reagent tank. wouldn't that cause conflicts with pills being administered by medics if they give all those pills to a marine and then it just stops working as it mixes inside the body into "disgusting mixture"? Do you plan to make reagent tank mixing impossible then?

kommikas124 avatar Apr 05 '25 20:04 kommikas124

I'm curious on how it's gonna be implemented as there is no special chemistry reaction called: "unga juice" it's just many different medicines put into a reagent tank. wouldn't that cause conflicts with pills being administered by medics if they give all those pills to a marine and then it just stops working as it mixes inside the body into "disgusting mixture"? Do you plan to make reagent tank mixing impossible then?

The recipes are blacklisted from reacting inside mobs.

JackieEstegado avatar Apr 05 '25 20:04 JackieEstegado

worst PR of the year

sippykot avatar Apr 05 '25 22:04 sippykot

balance feedback, especially unhelpful feedback, goes on the forums in the form

hry-gh avatar Apr 05 '25 23:04 hry-gh

Feel free to request this be reopened when you feel like tackling the requested changes, as it stands this isn't the solution and Nivrak's suggestion would work better.

Detective-Google avatar Jun 02 '25 17:06 Detective-Google

Reopening at the request of the author.

Steelpoint avatar Nov 04 '25 13:11 Steelpoint

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 05 '25 15:11 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Nov 06 '25 02:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 07 '25 15:11 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Nov 07 '25 15:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 07 '25 15:11 cm13-github

awesome

Nihisohel avatar Nov 07 '25 15:11 Nihisohel

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Nov 07 '25 16:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 11 '25 05:11 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Nov 11 '25 05:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 28 '25 02:11 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Nov 29 '25 02:11 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Dec 14 '25 19:12 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Dec 15 '25 16:12 cm13-github