cmss13-devs
The Solar devils return to the Golden Arrow, Solar devils can now spawn naturally[Feat: The Midway and Tripoli]
todo
- ✅ wait for #7193 to be merged
- ✅ ~~wait for #8130 to be merged, to use sprites/code from it~~ Steelpoint's waiting until this PR is merged first.
- ✅ ~~wait for #8379 to be merged, so that the Midway can actually be an ERT shuttle~~ Solar devils will use regular ERT shuttle.
- :x: ~~wait for #8238 to be merged (as this PR uses loose SG ammo boxes)~~ (This PR now adds its own SG ammo boxes, but not regularly obtainable)
- ✅ expand the almayer landing zones and add the midway as the Solar Devils distress shuttle
- ✅ make sure it all works
About the pull request
The Solar Devils (full squad) ERT can now spawn, with a 15 prob chance of doing so.
Adds a modified version of the Golden Arrow, ported from https://github.com/cmss13-devs/cmss13-pve/pull/476 as the homebase for the Solar Devils ERT. Has almost everything that the PVE version does, including the Tripoli.
Adds SG bullet boxes from #8238, currently only found on the Golden Arrow. (cannot be created manually, cannot spawn in ASRS, etc etc, they exist solely for the Garrow).
The Garrow has been modified to be smaller, only having the main floor and a small section of its maints. All the elevators are gone, sorry.
Ports quite a few sprites over from PVE, including the whiteboard, a Working Joey container sprite, cupboards, cargo crane tracks, Midway and Tripoli-related dropship sprites, ~~and the maptable (will be swapped out when #8130 is merged).~~ maptable removed
Explain why it's good for the game
The Golden Arrow is super cool looking, I wanted to port it over for when I try to make the Solar Devils have an actual chance of spawning (outside of adminspawn), so that others can see the Garrow.
I've always wanted to see Solar devils as a natural spawning ERT, and while they are sovl they aren't massively overpowered, rocking unmodded Mk1s with AP as their weapon of choice (As compared to PMCs/RMC which are much stronger).
Testing Photographs and Procedure
Changelog
:cl: Private-Tristan, Nauticall add: Solar Devils ERT can now spawn naturally, with 15 probability mapadd: The Golden Arrow has been ported over from PVE, and modified to be a bit smaller. mapadd: The Midway and Tripoli as admin spawnable shuttles. code: Renamed some of the PVE floor tiles to match what they're called on the PVE codebase (and a few had wrong dirs). imageadd: a LOT of sprites from PVE. /:cl:
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
![cmss13-ci[bot] avatar](https://avatars.githubusercontent.com/u/84123730?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
I have given up attempting to learn signals.
If tacmap table still needs to respect area power I will kill it and the Golden Arrow will live without.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
replaced everything with props and tossed out the Tripoli should be ready now:tm:
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself