(Requesting TM) Trapper Renovated

[TheKillfish]

About the pull request

Renovates Trapper to be less of an annoying shit for people to fight and less of a boring shit for people to use. General beats of Trapper remain but with overly safeness and spamability hopefully nuked along with adding the visual and auditory flair that it completely lacks (forreal, Trapper has had 0 audio tied to any of it's abilities).

• Unmentioned stat changes and unmentioned speed burst passive have been removed. Now the only statistical drawback Trapper has is losing 100 max health (previously Trapper would lose 60 health, all armor and a hefty chunk of speed but got a hidden speed burst upon being hit by harmful projectiles).

• Deploy Traps has had minimal changes as it has worked just fine. Cooldown has been minorly shortened (20.5 seconds to 18 seconds) and rooting duration upped to 2.5 seconds to compensate for empowering being removed (previously had 1.75 second root that could be empowered into a 3 second root). Using requires a short 0.5 second channel cancelled by movement.

• Acid Mine has been renamed Acid Mortar, and now has slower AOE delay (13.5 to 50, but trapping someone cuts it to 25) with a longer cooldown (5.5 seconds to 14 seconds) but deals more damage (45 damage to 70 with 10 armor piercing, and dealing double damage to barricades). Still is very capable of destroying cades but should give marines more breathing room between between uses. Using requires a short 0.5 second channel cancelled by movement.

• Acid Shotgun also has had minimal changes aside from the code being made less dumb, getting shorter cooldown (13 seconds to 10 seconds), and having damage altered (from 10 damage a pellet to 6 damage, but trapping someone brings it up to 9).

• Trapper's long range sight has been ditched, and instead retains base Boiler's long range sight.

Additionally some single vars have been nuked as well as all code for Acid Lance, because nothing uses it and barely anything has touched it's code in 5 years.

Explain why it's good for the game

Much loathed yet very much needed strain that has not been touched by anyone in 5 fucking years bar single letter var removals, define redefs/refactors and other flavour/background only tweaks finally gets a glowup. The overall core behind Trapper is still the same as are the core of its abilities, hence me refering to this as a renovation rather than rework, but much of the bullshit (Acid Mine spam from a screen away) has hopefully been removed and the lack of certain things (sound effects and gratifying visuals) have been added.

Hopefully the end result is Trapper being more engaging for marines to deal with while giving the Trapper themself more to do besides sit in one place and spam one ability. Even if the balance is not recieved well, at least the stain text actually tells you all that you trade and all that you gain (which it didn't fully mention) and the abilities have sounds (which they also didn't before).

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

:cl: Killfish balance: Trapper has been renovated, giving it the attention it has not gotten in about 4-5 years. Acid Mine is now Acid Mortar and is slower but hits harder, and Trapper's Long Range Sight is no more in favour of keeping base Long Range Sight, so they'll have to get closer to danger. Trapper's stats now are the same as base Boiler except for health, which is now even lower, and synergy between abilities have been changed; Deploy Traps is now the source of buffing the other abilities, and Acid Shotgun has been tweaked appropriately for being used more often. refactor: Parts of stuff used by Trapper have now been unjanked. del: Acid Lance code and code related to Trapper's Empower passive removed. /:cl:

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cmss13-ci[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[Drulikar]

Stale exempt until tested.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.