cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard
verified publisher icon cmss13-devs

Particle effects [TM ONLY]

Open Doubleumc opened this issue 1 year ago • 3 comments

About the pull request

Adds particle effects for projectile impacts and explosions.

This is a mixture of TG and TGMC implementation along with the example provided by https://github.com/cmss13-devs/cmss13/pull/6946 .

Not currently meant to be a comprehensive port of every effect on TGMC, but to get some big effects and the systems behind them.

Definitely needs some large-scale testing, especially on the performance side. I want to ensure nobody suffers from the addition of particles. Am investigating methods of per-player particle options.

Explain why it's good for the game

Significantly more options for visual effects.

Testing Photographs and Procedure

Screenshots & Videos

https://streamable.com/3cmspv

Changelog

:cl: add: Added projectile impact particle effects del: Removed old explosion shrapnel effect add: Added explosion particle effects /:cl:

Doubleumc avatar Oct 06 '24 02:10 Doubleumc

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Oct 06 '24 05:10 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Oct 06 '24 07:10 cm13-github

Not sure if I like these or not, but it's interesting. I know that I do like the current "shockwave effect", it would be a shame to remove that completely, having the shockwave combined with these would actually be cool, if that's possible.

Zenith00000 avatar Oct 10 '24 23:10 Zenith00000

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Oct 26 '24 11:10 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Oct 27 '24 00:10 cm13-github

Stale exempt because incompatible with xeno endgame currently.

Drulikar avatar Nov 01 '24 04:11 Drulikar

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Nov 19 '24 13:11 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Dec 05 '24 02:12 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Dec 31 '24 17:12 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Jan 29 '25 19:01 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Feb 10 '25 18:02 cm13-github

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar Apr 03 '25 14:04 cmss13-ci[bot]