cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Verifying if the queen is dead on check_bloc

Open Ibessas opened this issue 1 year ago • 3 comments

About the pull request

Fixes Issue #7223

Verifying if the queen is dead on check_bloc to prevent playing the sound. Tested on almayer with dead queen body, dead drone body ade dead crusher body

Explain why it's good for the game

Fixing bug to improve game quality

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags. Test: https://www.youtube.com/watch?v=kn_JU-B11pg

Changelog

:cl: fix: Verifying if the queen is dead on check_bloc /:cl:

Ibessas avatar Sep 26 '24 21:09 Ibessas

uhh... if another queen evos won't it make the other queen corpse start knocking down again/

private-tristan avatar Sep 28 '24 05:09 private-tristan

uhh... if another queen evos won't it make the other queen corpse start knocking down again/

Looking after it

Ibessas avatar Sep 28 '24 15:09 Ibessas

Just check mob's state instead???

queen.stat == DEAD

Or even better unregister the signal from the mob on queen's death

ihatethisengine avatar Sep 29 '24 01:09 ihatethisengine

What a problem to unreg signal on proc death?

BlackCrystalic avatar Oct 16 '24 04:10 BlackCrystalic

by the way, you need to mark your prs as ready to review when you'd like a maintainer to look over and merge

CleanShot 2024-10-26 at 21 21 34@2x

hry-gh avatar Oct 26 '24 20:10 hry-gh