cmss13-devs
Upp req console, tank and cas printers
About the pull request
spliting the work on HvH gamemode to more PRs for easier rewievs. when making this PR I was told req shuttle would be repalced with new system in a week, it has been few months so I am gona add upp shuttle in future PR
Explain why it's good for the game
more flexible and properly instanciented consoles and its own printers and req for UPP is greate for making events
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the <details> tags.
Changelog
:cl: add: UPP req console, dropship part fabricato and tank part fabricator /:cl:
okey I have added the consoles for req, cas and tank, I have not done the part regarding upp req elevators as paulrpg is working on changing them intwo new shuttle code
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
address ci fail (indestructible no longer exists)
wrongly looked at merge conflict when solvng it, I tought that the ndestructible was added not removed
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
![cmss13-ci[bot] avatar](https://avatars.githubusercontent.com/u/84123730?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
I've done some testing.
The UPP requisitions system appears to be fully functional. I can order items, the elevator arrives and departs, and the railings and gears will work as the USCM does. Questions on the balance cost of the items is a separate issue but the costs appear to be similar to USCM pricing.
The CAS vendor works properly.
The Tank vendors menu appears to crash whenever I use it. But the Tank vendor even for the USCM is broken since its depreciated for the newer vendors in the hanger, so this is beyond the scope of this PR I think.
not really interested in a bespoke supply controller for upp, it'd be better to factionate the existing one
that is what the PR does, or at least aims to. if there are places where it is not the case please inform me
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.