cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Additional Visual Effect

Open BlackCrystalic opened this issue 1 year ago • 11 comments

About the pull request

Port of some funny visuals from TGMC

Changelog

:cl: BlackCrystalic add: additional visual effects for explosions & bullet hits /:cl:

BlackCrystalic avatar Aug 14 '24 02:08 BlackCrystalic

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 14 '24 02:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 14 '24 02:08 cm13-github

need picturesss

deathrobotpunch avatar Aug 14 '24 03:08 deathrobotpunch

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 14 '24 04:08 cm13-github

Not all effects were ported or not all are working, also the circle of light looks very buggy and old, tgmc has fire effect for it, which as i can see, isn't ported.

Comparison of changes in your pr and tgmc explosion

dreamseeker_CBr4Gd5cls dreamseeker_lRGJqotqHv

Blundir avatar Aug 14 '24 11:08 Blundir

Wall bullet impacts are working fine, but mob ones are either not working or not ported

dreamseeker_SN04JZ4LMo

dreamseeker_QEiPtQRmhh

Blundir avatar Aug 14 '24 11:08 Blundir

Effect on hit mob is not integrated, Explosions: Probably I ported old port of it, or without some fix that I made later... I ported a port from other CMSS, so funny happens :3 I'll check it later

BlackCrystalic avatar Aug 14 '24 11:08 BlackCrystalic

The shock wave effect ends too soon and the light remains for too long, also i think explosion power doesn't change the explosion effect size, like on tgmc dreamseeker_xYtbtZxyU8

Blundir avatar Aug 14 '24 14:08 Blundir

The splatter and wall impact looks fine dreamseeker_o4NjrEpwFe

dreamseeker_0ZWc3lsjZC

Blundir avatar Aug 14 '24 14:08 Blundir

Also there is rocket launcher back blast and gun fire smoke effects, in case you want to port them too.

Blundir avatar Aug 14 '24 14:08 Blundir

Also i think this was added by mistake chrome_Yv4TN0YKyd

Blundir avatar Aug 14 '24 15:08 Blundir

Nuh uh, I lazy to do it now, and not interested anymore in it, so... I'll close this pr and delete branch NOW, if anybody want to finish this, do it

BlackCrystalic avatar Aug 27 '24 22:08 BlackCrystalic