cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Mines Boom 2: non-electric booglaoo

Open LynxSolstice opened this issue 1 year ago • 7 comments

About the pull request

This PR is a revival of the original PR here: (https://github.com/cmss13-devs/cmss13/pull/3615). It adds antitank mines as an alternative/additive to claymores that target larger xenos. As well as a framework for making more bury-able mines.

Explain why it's good for the game

It offers a defensive/ambush utility to engineers that can be countered by xenos (dug up and acid'd) but that deters T3s.

Testing Photographs and Procedure

Screenshots & Videos

TESTING VIDEO

Changelog

:cl:LynxSolstice, Totalepicness5, Thwomper, Sir.Crow, Silencer_pl add: Adds anti tank mines and the framework for creating more bury-able mine types. balance: Adds M19 Antitank mines to the engineer vendor, the req vendor with a scale of (round * 2), adds the M19 antitank mine. spellcheck: ((title suggested by Silencer_pl)) Added descriptions for the Antitank Mine. code: Original code by Totalepicness5, maintenance of the code by LynxSolstice. refactor: Mine code flesh out more. (Refactor by Totalepicness5) imageadd: Adds a sprite for an unburied and a buried Antitank Mine (Sprites by Thwomper), and a Mine box (Sprites by Sir.Crow) /:cl:

LynxSolstice avatar Aug 09 '24 09:08 LynxSolstice

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 09 '24 18:08 cm13-github

Badass, although i suggest renaming them. They dont seem to cause much AP damage at all and mainly stun after all. The name shouldnt confuse people what the mines do.

TheManWithNoHands avatar Aug 09 '24 22:08 TheManWithNoHands

Badass, although i suggest renaming them. They dont seem to cause much AP damage at all and mainly stun after all. The name shouldnt confuse people what the mines do.

Upped the damage in the next commit.

LynxSolstice avatar Aug 10 '24 01:08 LynxSolstice

https://youtu.be/2ZByfXpnNok

LynxSolstice avatar Aug 10 '24 05:08 LynxSolstice

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 11 '24 01:08 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 22 '24 14:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 27 '24 02:08 cm13-github

address ci fail

Will work on addressing this.

LynxSolstice avatar Oct 13 '24 03:10 LynxSolstice

Passed CI

LynxSolstice avatar Oct 13 '24 04:10 LynxSolstice

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar Oct 27 '24 00:10 cmss13-ci[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Dec 10 '24 17:12 cm13-github

Fixing conflicts

LynxSolstice avatar Dec 17 '24 09:12 LynxSolstice

fix conflicts

hry-gh avatar Jan 30 '25 15:01 hry-gh

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

cmss13-ci[bot] avatar Feb 11 '25 22:02 cmss13-ci[bot]