Spatial Sound Tracking [TM ONLY]

[Doubleumc]

About the pull request

Sound position updates as the hearer and source move around.

Can test merge. Needs to be tested at scale, see if the architecture is appropriate for CM's demands.

Don't full merge. While (hopefully) fully functional its current form is meant to be restrained proof-of-concept before integrating other aspects and touching a ton of files. Tracking playing sounds is a powerful tool that opens up a lot of possibilities, if done in a way the server can handle.

Explain why it's good for the game

More immersive sound effects.

Testing Photographs and Procedure

Mob sounds, turf sounds, dropship sounds, interior sounds all appear to be working. Playing 1000 warcries at once hitches on start but updates smoothly. Cannot gauge beyond that with only one client. Profiler logs would be greatly appreciated.

Includes debug admin toggle for the entire spatial update system. Allows round to continue if the system chokes.

Includes debug admin verb to set a minimum sound length for the spatial update system. Exclude shorter/less important sounds to tweak performance.

Changelog

:cl: soundadd: sounds follow their source /:cl:

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[Doubleumc]

causing sounds to cut off/become delayed (most noticeable when there's a shitton of sounds trying to be played in a short period)

the sounds were super fucked when that OB landed

Making changes based on feedback.

[Doubleumc]

Had nulls in the list of hearers (never trust a client) and sometimes null turfs for spatialization. Added checking and some debug messages for that.

[fighterslam]

Right, so having an item in your hand make a noise seems to be a little weird. Guns are audible, but they feel off and I'm not sure how to describe it. Cool idea for the PR, though.

A larger thing I noticed was the Liaison's automated briefcase. Whenever you dispense something from it, it usually makes a printing noise - the same printing sound you get whenever a fax is received. It was COMPLETELY inaudible with this testmerge.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cmss13-ci[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself