cmss13-devs
XM-CL ANCW: Caustic Armor for research
About the pull request
Adds a new set of armor to the game. The XM-CL ANCW. An Armor set that research can print for a step price. It provides heavy Bio protection, a bit better bomb protection and heat protection, but in turn, it is much less effective against bullets and reacts harsher to electric shocks.
It has even an actual place in the lore, being that its based on the Z-110 ANCW. An anti xenomprh armor that uses gel to turn acid into basicly water. The chest pice contains its lore blurp. https://avp.fandom.com/wiki/Z-110_Acid_Neutralizing_Combat_Wardrobe
Prices are WIP and definitly need a second opion.
Explain why it's good for the game
Its another thing research can buy using their printer. The bioprinter is currently our fairest pointshop we have, being the only one that doesnt gain points by being AFK. And we have one shop where you can be AFK to earn metal, wich is one of the strongest things in the game.
The printer already has a lot of great options people can chose to spend their points on. Expanding the list of avalibel things to buy from it, gives the printer and research much more varity. So they hopefully dont do the same every round. There is already the thing that a lot of researchers only use the printer to make more points for stims. So giving the printer more atractive options would help reduce the over reliance on stims.
Testing Photographs and Procedure
https://imgur.com/a/TpXl0oc
Changelog
:cl: TheManWithNoHands
add: Added Caustic Armor imageadd: added icons for new armor, helmet, gloves, boots, uniform and kit
/:cl:
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
More things for biopoints is good. but how does it fair up with boiler nero gas?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Doesnt do shit against any kind of gas. There are no gas filters after all, the ones we have are make belive. Only effects spit acid, prea acid ball and acid spray. Not sure about body acid though.
The one thing this armor does is allowing you to flip a spitter off because they are useless against you.
Not gonna resolve merge conflicts until this is ready for merge. My python is fuckd so i cant install the hooks and need to resolve it manually. Aint doing that every time.
A few notes, though I wouldn't sweat the dates too much given the whole mess of timelines in the base material:
- Consider renaming the chestpiece to the XM3-ANCW, making it an experimental offshoot of the standard M3 pattern, and the helmet to XM10-ANCW. The Z-110 designation is almost certainly a corporate thing, can't think of any reason the military would be using Z and the format's off too.
- The source material (Dark Horse comics) was somewhere around the 2230s I believe, which is ~50 years past us, so this would make more sense as an experimental anti-acid system tested at this point and then possibly picked up and refined by the Grant Corporation at some point in the future, and made into the Z-110.
- The lore blurb doesn't work for the above reason, rather than directly porting a reference to Grant Corp, consider how to keep the general concept of the item while accounting for rounds happening in 2182. USCM and WY working together on an experimental project is fine, as are the mechanics of how the ANCW system works, but think about why it requires points to produce. Here's an some example lore, you can use it directly or edit as desired:
The armor needs to be produced because XX-121 samples were needed to finalize the ANCW system, as that data wasn't provided by WY nor the USCM. This could be because WY isn't willing to admit they have samples/easy access to xenomorphs, and the USCM not having it available, but it doesn't matter and this doesn't need to be specified Consequently the ANCW system and the armor design was merely theoretical. The Almayer's researchers, being associated with WY and the USCM, had access to the experimental designs, and now with the unexpected fortune of stumbling on an XX-121 infestation, can obtain the samples to produce a few prototypes.
- The explanation of being stripped down is fine to keep, though the reasoning might work better as being stripped down from the M3 base to fit in the ANCW system.
- The extended description needs proofreading overall. There are several dropped letters and grammatical issues, but I'll hold off suggestions for that until the description is updated to deal with the timeline issues.
- If you wanted to enhance the uniqueness of this research item further, there's a lot of room left with the ANCW and CN-Gel concepts. You could make the CN-Gel an actual resource value the armor uses, whether to give enhanced or 100% acid resistance until depleted, or rip the code from armor plates and make a CN-Packet 'plate' item that gets attached to this armor only, and soaks a certain amount before breaking.
- Boiler attacks are still acid aside from neurotoxin, and if the armor has a gas mask and the ANCW system, it should be reducing that impact. It'll take a bit of extra code though, so that's also optional unless you think you know how to implement it. It shouldn't be 100% boiler gas protection even if you add any of the above buffs though, because it's not an airtight suit.
Those additional possibilities are all optional though. It's acceptable as is, and having the CN just be an explanation for why it has higher-than-normal acid protection could be because it's a not-refined form that can only partially negate the effects.
Thats very helpful, thank you. I posted about this in the lore chanel on discord already but got no feedback there sadly. Gonna work on implementing the notes you gave. Also thank you for offering to proof read it. English aint my first language.
Gonna drop the Grand copr refrence and just keep it as the material i mentioned in the lore blurp, xeno spit. Only said it offhand in the lore blup on purpose. So you reading "oh this is an interesting pice of science" and you sligthly skim over the word "spit" and take a minute to realise what that means. Maybe even just thinking theres no greater meaning. Even though the fancy gel marines run coverd with is literally just xeno spit. Im pretty sure you missed that detail because of that.
I found a couple refrences that xenos insides are still somewhat vunrebal to acids. So it would make sense if their own saliva can neutralise acid that is on the victim they swallow. That was the reason why it needs biomatter points to produce it. Becauce without the compound, its literally like wearing a kiddy pool around your chest with 10$ storm trooper armor. And also its hilarious.
But on some points:
- Good point on the renaming of the armor. But i will need the whole set to be the same name. Also i dont think calling it ANCW outside its descpritions is a good idea. Name needs to be short and snappy after all. Likly just gonna call it XM3 if im lazy.
- Not gonna make it actually use up rescources. Thats mostly just flavor to use already exsiting lore for it. Gameplay first, lore second. Having to actually refill it would be a pain in the ass after all, and nobody will pick it. The Z-100 did magicly make infinit ammounts of its gell, so i think having the stored gel be a compount that expands drasticly into a gel under the rigth condicions is fine. Basicly like spray foam. Better then just making gel from nothing.
- I did plan on giving the Gas mask a use, but i then found out we have no system at all in place for gas masks to use. Every masks has some var for that stuff, but they are all empty. Every gasmask we have is purly cosmetical. And i dont know how to make a gas filter system from scratch. Besides, this way the armor isnt dummy OP and plays more fair against. Imagine if the armor made marines able to tank spitters and also boilers. Xeno mains would riot.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
im not gonna touch the .dmi conflicts until the pr is aproved to be merged balance wise. I have to do this by hand everytime a Pr gets merged that touches any of those files. NO.
fix conflicts, The price might be too high for what it is but we will see.
I keep having to resovle the conflix again and again by hand because i cant make the hooks work. So no, im waiting until this is aproved balance wise. The reason why this isnt going stale is because i used to immediatly .dmi errors.
Also stop setting my Pr on draft, especially if half your suggestions are just about subjective phrasing.
fix conflicts, The price might be too high for what it is but we will see.
I keep having to resovle the conflix again and again by hand because i cant make the hooks work. So no, im waiting until this is aproved balance wise. The reason why this isnt going stale is because i used to immediatly .dmi errors.
Also stop setting my Pr on draft, especially if half your suggestions are just about subjective phrasing.
You should seek help getting the hooks working. As far as I knew they were working for you. The last thing you were told to do IIRC was to clear your python cache so you can install the new python version.
It is standard procedure for maintainers to draft a PR when a review is made. A drafted PR & conflicted PR is remove from the review queue.
You should seek help getting the hooks working. As far as I knew they were working for you. The last thing you were told to do IIRC was to clear your python cache so you can install the new python version.
Yeah, i will tinker around a bit again and see if i can get it to work. If not, i ask on the discord again.
It is standard procedure for maintainers to draft a PR when a review is made. A drafted PR & conflicted PR is remove from the review queue. Ahh, got very confused by it. First time i saw it happen like that. Sorry about that then.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
something something, needs likly a rework and/or major rebalancing
pr appears to be stale (no commits for a couple weeks), feel free to ask us to reopen/open a new pr when you're working on it again
