cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Event Spawn: Synthetic K9 Rescue Teams

Open blackdragonTOW opened this issue 1 year ago • 24 comments

About the pull request

Adding a full gameplay loop of the Synthetic K9s that have been historically run by Admins, except as a full fledged Species and Job set that way it's much easier to set up, requires no oversight (the process was originally a 20 minute set up and then needed to be baby sat every time the K9 would be damaged).

The gameplay loop is this:

  1. For the event a Squad Corpsman with RP potential is identified
  2. We 'Create Human' a K9 Synthetic and ckey attach an eligible player
  3. We spawn in the K9 Synthetic Requisitions Vendor
  4. The K9 selects the customization and gear options as expected for anyone gearing up
  5. The K9 hands off the Handler kit to the Corpsman (identical to the Sniper Spotter process)
  6. The K9 and newly appointed "K9 Handler" now perform Corpsman duties except with a dedicated helper

Features for this include:

  • Unique TacMap icons for K9 and K9 Handler.
  • Unique MarineHUD icons for K9 and K9 Handler.
  • Emotes for the K9 for bark and growl.
  • Carrypacks for medical supplies, basic cargo, and an MP vest
  • Boosted senses for the K9 unit, with a Scent Tracker to track down friend and foe, darkvision, and Binocular Vision to see distant
  • Self-input names/gender assignment

Additional Improvements include:

  • NO_OVERLAYS flag for future species/situations where we want no gear overlays to appear
  • Fixing species being blacklisted on all emotes when we want to only blacklist them on base emotes (warcry, golfclap, etc)

Sound Notes:

  • All sounds normalized to -6db
  • Royalty free source: pixabay.com

Sprite Notes: K9 sprite based on the coyote from mojave sun

Explain why it's good for the game

This gives the K9 Synth rescue team a full gameplay loop, good player engagement, helps bolster RP while also making an event that isn't goofy or silly.

Testing Photographs and Procedure

Screenshots & Videos ![Capture](https://github.com/cmss13-devs/cmss13/assets/31581761/5ece05b0-02cd-4c67-bdc3-bd55fc6d45ca) ![k9](https://github.com/cmss13-devs/cmss13/assets/31581761/9aadcac8-6fb9-41a3-b45b-ca264d7a5810)

Changelog

:cl: add: Added Synthetic K9 Rescue Teams fix: Monkeys no longer have access to marine emotes AND now have access to their own emotes but were blocked from. code: Added a NO_OVERLAYS flag for species should we ever want a species to not use onmob overlays. refactor: Altered emote whitelisting and blacklisting so that species that were blacklisted out of the basic emotes will able to be whitelisted for other emotes soundadd: added dog sounds for Synthetic K9 Rescue Teams imageadd: added icons for Synthetic K9 Rescue Teams /:cl:

blackdragonTOW avatar Jun 17 '24 06:06 blackdragonTOW

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Jun 17 '24 06:06 cm13-github

ALSO THIS IS MY FIRST SERIOUS FULL FEATURE EVER. I APPOLOGIZE FOR ANY SHIT CODE OR PAINFUL STRESS CAUSED TO MAINTAINERS FOR VIEWING MY HAMFISTED CODE ATTEMPT.

blackdragonTOW avatar Jun 17 '24 07:06 blackdragonTOW

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Jun 19 '24 04:06 cm13-github

A nesting doll of problems. Merge conflicts resolved but that broke my code elsewhere. Working on it now.

blackdragonTOW avatar Jun 19 '24 05:06 blackdragonTOW

I believe all notes have been addressed!

blackdragonTOW avatar Jun 19 '24 05:06 blackdragonTOW

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Jun 27 '24 01:06 github-actions[bot]

Overall I like the sprites, just need to do the adjustments/answer clarifications above. ^^

nauticall avatar Jun 30 '24 11:06 nauticall

Stray pixel on the "dead" sprite here. image

I'd prefer something like a "K" over these. They're too vague as is. image

Is this supposed to be empty? image

Assuming these are "male/female" and not "headed/headless", why does the F sprite have a head but the M doesn't? image

  • Stray Pixel removed!
  • While I think it's important to keep the visual language of what job the handler has, I'll change both of these to the standard 6x6 capital "K"
  • Originally this wouldn't be used in any capacity and it needed something to point to to not throw an error, I think a fallback icon should do, I've made it the W-Y jumpsuit for the time being, though it will not be seen (this makes it so if it is, we'll know)
  • Great catch! I made the male headless and just completely forgot to duplicate it to the female version

blackdragonTOW avatar Jun 30 '24 21:06 blackdragonTOW

Capture The new Marine HUD icons for reference.

blackdragonTOW avatar Jun 30 '24 21:06 blackdragonTOW

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Jul 07 '24 06:07 cm13-github

Pain.

blackdragonTOW avatar Jul 07 '24 06:07 blackdragonTOW

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Jul 07 '24 06:07 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Jul 07 '24 06:07 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Jul 07 '24 06:07 cm13-github

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

github-actions[bot] avatar Jul 15 '24 01:07 github-actions[bot]

Stale exempt until code reviewed

Drulikar avatar Jul 21 '24 04:07 Drulikar

bless

blackdragonTOW avatar Jul 21 '24 04:07 blackdragonTOW

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 06 '24 22:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 07 '24 02:08 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 18 '24 08:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 18 '24 20:08 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 21 '24 01:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 21 '24 05:08 cm13-github

The conflict dodge continues

blackdragonTOW avatar Aug 21 '24 05:08 blackdragonTOW

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 22 '24 14:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 23 '24 01:08 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar Aug 23 '24 14:08 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar Aug 23 '24 18:08 cm13-github