cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Research xenomorph "dissections"

Open kiVts opened this issue 1 year ago • 20 comments

About the pull request

This PR is a part of a larger research "rework"(which is already half coded too. this is atomized) if you want to read the research document more detailed, go to discord thread in contrib projects.

On init, each xeno is given a heart. When xenomorph dies, those with surgery skills can operate it to take it out, this is however a dangerous process, which can lead to acid blood spraying everywhere and burning the surgeon severely, hazmat suits advised.

to start, begin by cutting the carapace on the head with a saw, then open it with a retractor, Use the pict(or any suitable item) to cut the organ connections, and hemostat(or hands) to take it out.

Currently, there's only one use for it: the Xenomorphic analyzer. When inserted, you can recycle the organ for "biomass" points. these points vary for each xeno, runner giving 500, or queen giving ~7k

WIth biomass points you can print "upgrades " to autodoc, or sleeper, or simply research credits. upgrade for autodoc comes in four variants, Internal bleeding repair, broken bone repair, organ repair and larva removal.

sleeper gives better chemicals and ~triples dialysis speed.

credits give two points per X biomass(currently 2k)

now, onto technical part.

I made surgery work on xenos with little adjustments. its not too goofy from the first look and actually pretty nice. Cant guarantee nice code though.

datumized the upgrades hopefullyish-goodish with purposeish

This is wip, most of it is ready but I need to do

  • [x] Put in the sprites for the analyzer, provided by zenith
  • [x] actually map in the board( yes research will need to call MT to construct the machine)
  • [x] clean the code of debug messages
  • [x] add more upgrades. its very bare.(but which exactly)
  • [x] clean up tgui and make it better now that I know quite a bit more about it.(aka add dropdown menu)
  • [x] fix any shitcode pointed out and hope for the best
  • [x] readd burn damage. removed because of testing purposes (actuall braindead me)

The main features, are, however, done, and it works.(besides the "xeno specific" upgrades e.g. spitter organ giving anti acid points, but I think its kinda meh)

Explain why it's good for the game

research is a stim producing factory. bad bad. fix now, this design is very human. with this pr It will still be stim producing factory, but with later rework we will fix it trust me bro, for now this will stir up the gameplay of it and ease the merge process(in two years btw)

This will, absolutely, will need some adjustments to pricing and other balance changes to not tilt the scales of research credits too much or not to make some things too good:tm:

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

:cl: Kivts, SubjectD9341, Zenith. add: Xenomorph Harvesting Surgery. Allows research to operate dead xenomorphs to take out their organ. add: The Xenomorph analyzer, uses organs extracted from dead xenomorphs, which when processed gives points to spend on physical upgrades. add: a number of machinery upgrades for autodoc, sleeper, and other upgrades or bonuses research can decide to spend their points on del: passive generation increase of research credits is removed /:cl:

kiVts avatar Apr 24 '24 05:04 kiVts

right. need to also remove the old research stuff from maps too.

kiVts avatar Apr 24 '24 05:04 kiVts

still missing some sprites and need to map the board in, but the code is essentially done. Except upgrades(over what I already added twice). more to come.(the norm)

kiVts avatar Apr 26 '24 05:04 kiVts

image this is how it looks like mapped in. I scrapped the board idea but still. its there

kiVts avatar Apr 27 '24 04:04 kiVts

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar May 05 '24 17:05 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar May 05 '24 19:05 cm13-github

oh gowd...

kiVts avatar May 05 '24 19:05 kiVts

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar May 05 '24 19:05 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar May 05 '24 19:05 cm13-github

This pull request has conflicts, please resolve those before we can evaluate the pull request.

cm13-github avatar May 05 '24 19:05 cm13-github

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github avatar May 05 '24 19:05 cm13-github

Tested this in the game. was surprised when is saw the machines! had trouble opening higher grade Xenos like Ravavger. says (need higher grade tools) can you explain? also. I disagree on removing the passive generation increase of research credits because it makes us heavily depend on IOs even more. but overall its a good addition!

Toastina avatar May 10 '24 05:05 Toastina

Tested this in the game. was surprised when is saw the machines! had trouble opening higher grade Xenos like Ravavger. says (need higher grade tools) can you explain? also. I disagree on removing the passive generation increase of research credits because it makes us heavily depend on IOs even more. but overall its a good addition!

to operate on tier three and above you need a laser scalpel, found in the same machine you feed the organs into.

kiVts avatar May 10 '24 05:05 kiVts

image What does this mean? After hitting Process Biomass on a xeno organ, the sprite plays an animation, but it never gets processed. If another organ is added to the analyzer, it bugs out and has to be deleted and respawned. It seems like the Matter is never being processed. There was a runtime for this round (22128), but I'm not sure if it's the cause, or if it happened when the player initally put in two organs. After respawning the whole machine, it still doesn't seem to work correctly.

[2024-05-10 09:13:11.324] runtime error: Cannot read null.research_value

  • proc name: process organ (/obj/structure/machinery/xenoanalyzer/proc/process_organ)
  • source file: code/modules/reagents/chemistry_machinery/xenomorph_analyzer.dm,130
  • usr: null
  • src: Biomass Analyzer (/obj/structure/machinery/xenoanalyzer)
  • src.loc: the floor (155,162,3) (/turf/open/floor/almayer)
  • call stack:
  • Biomass Analyzer (/obj/structure/machinery/xenoanalyzer): process organ()
  • /datum/callback (/datum/callback): InvokeAsync()
  • Timer (/datum/controller/subsystem/timer): fire(0)
  • Timer (/datum/controller/subsystem/timer): ignite(0)
  • Master (/datum/controller/master): RunQueue()
  • Master (/datum/controller/master): Loop(2)
  • Master (/datum/controller/master): StartProcessing(0)

Edit: Matter = Null I have a pea brain, and I have no idea what it's supposed to equal. I can set the machine's biomass freely, and it'll print stuff, but it still refuses to actually process organs. image

dadlips avatar May 10 '24 09:05 dadlips

alright. tested it AGAIN last round by the time i write this. the machine is bugged. we put a runner organ in. didn't get any point. and then put a lurker's organ in annndd its stuck and cant process it

Toastina avatar May 10 '24 11:05 Toastina

I will fucking kirll myself

kiVts avatar May 10 '24 12:05 kiVts

image What does this mean? After hitting Process Biomass on a xeno organ, the sprite plays an animation, but it never gets processed. If another organ is added to the analyzer, it bugs out and has to be deleted and respawned. It seems like the Matter is never being processed. There was a runtime for this round (22128), but I'm not sure if it's the cause, or if it happened when the player initally put in two organs. After respawning the whole machine, it still doesn't seem to work correctly.

[2024-05-10 09:13:11.324] runtime error: Cannot read null.research_value

* proc name: process organ (/obj/structure/machinery/xenoanalyzer/proc/process_organ)

* source file: code/modules/reagents/chemistry_machinery/xenomorph_analyzer.dm,130

* usr: null

* src: Biomass Analyzer (/obj/structure/machinery/xenoanalyzer)

* src.loc: the floor (155,162,3) (/turf/open/floor/almayer)

* call stack:

* Biomass Analyzer (/obj/structure/machinery/xenoanalyzer): process organ()

* /datum/callback (/datum/callback): InvokeAsync()

* Timer (/datum/controller/subsystem/timer): fire(0)

* Timer (/datum/controller/subsystem/timer): ignite(0)

* Master (/datum/controller/master): RunQueue()

* Master (/datum/controller/master): Loop(2)

* Master (/datum/controller/master): StartProcessing(0)

Edit: Matter = Null I have a pea brain, and I have no idea what it's supposed to equal. I can set the machine's biomass freely, and it'll print stuff, but it still refuses to actually process organs. image

Because I qdel-null earlier in the code and dont pass the organ value, I tested it with my 1 am brain and called it a day when it "worked" once.

kiVts avatar May 10 '24 12:05 kiVts

I demand an ability to eat xeno organs like their fruits and meat

Danil154322 avatar May 10 '24 14:05 Danil154322

Took off TM for a round or two for event purposes, will pop back on after :)

realforest2001 avatar May 10 '24 20:05 realforest2001

Question for the universal translator! does it translate what Xeno saying? I heard that it didn't work with Xenos. only with other humans.

2nd. how many points do I get if... dissect an abomination or a yautcha/Jamaican? Is that even possible?

(PS! Is there any chance you can increase the research point from 2-3 to 4? 1.5k points for 2-3 points is very steep! or reduce the point cost! sorry I just miss the increased passive point gain when clearance is upgraded haha)

Toastina avatar May 11 '24 23:05 Toastina

Question for the universal translator! does it translate what Xeno saying? I heard that it didn't work with Xenos. only with other humans.

2nd. how many points do I get if... dissect an abomination or a yautcha/Jamaican? Is that even possible?

(PS! Is there any chance you can increase the research point from 2-3 to 4? 1.5k points for 2-3 points is very steep! or reduce the point cost! sorry I just miss the increased passive point gain when clearance is upgraded haha)

  1. Yes, it works on xenos.
  2. 20k for a predaleian. cant do a pred
  3. its already enough, but maybe in the future.

kiVts avatar May 11 '24 23:05 kiVts

i know this is late but. can you move the APC location? if it was destroyed we cant repair it unless we destroy the sleeper machine.

Toastina avatar Jun 10 '24 11:06 Toastina

i know this is late but. can you move the APC location? if it was destroyed we cant repair it unless we destroy the sleeper machine.

shite. You can get in the sleeper and jump out to be on sleeper tile though so theres your answer

kiVts avatar Jun 10 '24 16:06 kiVts

but... if they dropship crashes you cant get in the sleeper. therefore you have destroy the sleeper.

Toastina avatar Jun 11 '24 15:06 Toastina

but... if they dropship crashes you cant get in the sleeper. therefore you have destroy the sleeper.

have someone throw you at the tile. regardless I will tackle it the next time Im doing a pr about it

kiVts avatar Jun 11 '24 18:06 kiVts