cmss13-devs
Some Vendors Not Breakable(by xeno slashing)
Testmerges
Issue has been ongoing for a loooong time.
Round ID
Round 21751
Description of the bug
Cigarette Machines, Hot Food Machines, and Hot Drinks Machines can be slashed by xenomorphs. Other vendors(medvendors, blood dispensers, nanomeds, etc), when slashed repeatedly, 'break' and fall to the ground allowing mobs to move through their tile. The aforementioned vendors just do not break and fall to the ground(tested as runner) when repeatedly slashed even though you get the message in chat of you "smashing the machine apart". May be related to the fact that these specific vendors eject some of their contents on the first instance of "smashing the machine apart" and thus stop checking to be actually smashed to the ground.
Me after slashing this particular cigarette machine 40+ times:
The chat log of me repeatedly slashing the vendor:
An example of a different vendor I slashed to the ground:
What's the difference with what should have happened?
Vendors should have consistency in their destruction. Not to mention is it kind of fun to break the vendors down from time to time.
How do we reproduce this bug?
- Become xeno with a slash attack.
- Find one of the 'machine' vendors mentioned above.
- Go slash happy.
- Stop before your mouse breaks after so many slashes.
Issue Bingo
- [X] Issue could be reproduced at least once
- [X] Issue happened in a recent (less than 7 days ago) round
- [X] Couldn't find an existing issue about this (https://github.com/cmss13-devs/cmss13/issues)
disarm intent and you can drop over the vendor after a wind-up.
Well aware you can knock over vendors with a windup but that does not break them. You can use grab intent as well to achieve the same purpose. The problem with this bug is that if you move one of these vendors to block movement, you now have a barricade that can not be slashed down but can be shot through which the other vendors CAN NOT DO because they can be slashed down. The windup to knock vendors down is also an incredibly tedious process. Far less fun than actually slashing things to bits. Further, the fact that these vendors have some weird 'eject contents' function upon the first time you roll the 'tearing it apart' slash suggests the vendor should be taking damage and makes me think this is a bug. When I say consistency among the vendors I also mean just consistency in general. Runners can not slash walls because they do not damage the walls but they can slash these vendors, chat log and slash sound included, which could cause a new player to expect them to break.
I don't know about in depth testing. The difference is simply https://github.com/cmss13-devs/cmss13/blob/master/code/modules/mob/living/carbon/xenomorph/attack_alien.dm#L951 vs https://github.com/cmss13-devs/cmss13/blob/master/code/game/machinery/vending/cm_vending.dm#L387-L388
I don't know about in depth testing. The difference is simply https://github.com/cmss13-devs/cmss13/blob/master/code/modules/mob/living/carbon/xenomorph/attack_alien.dm#L951 vs https://github.com/cmss13-devs/cmss13/blob/master/code/game/machinery/vending/cm_vending.dm#L387-L388
Oh, yeah then ignore my message lol