(WIP) Yautja Weapon Gimmicks, Round Two

[realforest2001]

About the pull request

Work on giving Yautja Weapons gimmicks again.

Explain why it's good for the game

Work in Progress. Allows Yautja weapons to have some flair beyond being variably effective sticks.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

:cl: add: Yautja weapons now collect blood 'charges' for using their abilites. add: Combistick now requires two hits to throw instead of one, but can store up to two throws. add: Scythe now can perform an AOE attack similar to Ravager Eviscerate, after five successful hits. add: Chainwhip can now bind a target with chains, tying them to within three tiles of the Yautja. balance: Reduced the probability for combistick blocking from 2/3 hits to 1/3 balance: Repaired the 15% hardcap on yautja mask knock chance. code: Changed damage variables on smartdisc to use existing defines rather than raw numbers. /:cl:

To-do:

• [x] Add binding to chainwhip
• [ ] Make certain abilities decay over time if not used, to prevent hoarding attacks on lesser foes (such as with the chainwhip) for more dangerous opponents.
• [ ] Consider abilities for the sword.

[RenaRenaRe]

Just so you know the block chance you changed only applies to pounces, since that seems to be the only time "combistick" is set to true. For xeno slashes it uses: if(I.IsShield() && !istype(I, /obj/item/weapon/shield) && (prob(50 - round(damage / 3))))

Keep in mind "damage" is always sent as 0 (at least for xeno slashes) so currently block chance for slashes is 50%, this PR changes specifically changes pounce block chance from 2/3 to 1/3. Just figured I'd point this out since the changelog says you changed the % of "hits" that it blocks which isn't really true.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[realforest2001]

Had to force because my git was freaking out for some reason and wouldn't let me pull anything

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[hry-gh]

re-open when this isn't wip and no conflicts

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cmss13-ci[bot]]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

[hry-gh]

pr has merge conflicts and hasn't been touched for a couple months, reopen when deconflicted and ready for review