cmss13 icon indicating copy to clipboard operation
cmss13 copied to clipboard

Remove unnecessary lobby xeno latejoin call

Open Drulikar opened this issue 1 month ago • 1 comments

About the pull request

This PR removes an unnecessary call for late joining as a xeno from lobby. Some reason Harry thought that attempt_to_join_as_xeno returned a mob, and if that returned mob wasn't larva it would need a transfer_xeno call.

But there shouldn't be any behavior change from this change because returning FALSE would just trigger the observe message. Returning TRUE would attempt /datum/game_mode/proc/transfer_xeno(xeno_candidate, mob/living/carbon/xenomorph/new_xeno) where new_xeno is TRUE but that then wouldn't pass if(!xeno_candidate || !isxeno(new_xeno) || QDELETED(new_xeno)) so it would do nothing anyways.

Explain why it's good for the game

Less dead code.

Testing Photographs and Procedure

Screenshots & Videos

https://youtu.be/gx3yR95evIM

Changelog

No player facing changes.

Drulikar avatar Nov 26 '25 04:11 Drulikar

Some reason Harry thought that attempt_to_join_as_xeno returned a mob, and if that returned mob wasn't larva it would need a transfer_xeno call.

just copypasta from the old lobby screen, i just get the diff IMG_1119

hry-gh avatar Nov 26 '25 05:11 hry-gh