node-ethernet-ip icon indicating copy to clipboard operation
node-ethernet-ip copied to clipboard

Fix for hanging timeout

Open jgentes opened this issue 4 years ago • 1 comments

When using methods from this library, there's a ~10 second delay before the process exits. It's due to the setTimeout in the promiseTimeout utility, which never gets cleared if the promise resolves successfully. Adding a clearTimeout here takes care of that.

jgentes avatar Feb 24 '20 19:02 jgentes

Pull Request Test Coverage Report for Build 147

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 51.102%

Totals Coverage Status
Change from base Build 141: 0.08%
Covered Lines: 474
Relevant Lines: 885

💛 - Coveralls

coveralls avatar Feb 24 '20 19:02 coveralls