node-ethernet-ip
node-ethernet-ip copied to clipboard
Port support
Description, Motivation, and Context
Adds support for use of additional tcp ports
How Has This Been Tested?
Still needs to be tested on a processor
Screenshots (if appropriate):
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
- [x] My code follows the code style of this project.
- [x] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
- [ ] This is a work in progress, and I want some feedback (If yes, please mark it in the title -> e.g.
[WIP] Some awesome PR title
)
Related Issue
Fixes #38
@jhenson29 Can you check to make sure there are no adverse effects from this change when you get some time?
Yes, I want to check with an actual router and using a different port. I should have time this week.
@jhenson29 Did you have a chance to check this in production?
@cmseaton42 I haven’t. I’ve been drowning at work the last few weeks and haven’t really had time to work on this project. I have some hardware physically connected. I just need to make some time to configure the router and run the tests.
Sent with GitHawk