cms-sw
Initialize members of HGCalClusteringAlgoBase
PR description:
This should fix several UBSAN warnings about invalid value of bool.
PR validation:
Code compiles.
This should fix the UBSAN warnings of the form
34434.758/step2:RecoLocalCalo/HGCalRecProducers/interface/HGCalClusteringAlgoBase.h:71:36: runtime error: load of value 255, which is not a valid value for type 'bool'
and
34434.758/step2:RecoLocalCalo/HGCalRecProducers/interface/HGCalClusteringAlgoBase.h:72:41: runtime error: load of value 255, which is not a valid value for type 'bool'
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49630/47172
A new Pull Request was created by @Dr15Jones for master.
It involves the following packages:
- RecoLocalCalo/HGCalRecProducers (reconstruction)
@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. @apsallid, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lecriste, @lgray, @pfs, @rovere, @salimcerci, @sameasy, @sethzenz, @vandreev11, @youyingli this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d746b/49984/summary.html
COMMIT: f6995dc0bef097f03299b6ae3313fe2378ca95a8
CMSSW: CMSSW_16_0_X_2025-12-15-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49630/49984/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 6 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 15 differences found in the comparisons
- Reco comparison had 4 failed jobs
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4280229
- DQMHistoTests: Total failures: 340
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4279869
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 227 log files, 198 edm output root files, 53 DQM output files
- TriggerResults: found differences in 1 / 51 workflows
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
