cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

L1 Emulator for revised model of topological trigger targeting hh->bbWW (single muon final state)

Open LukasEbeling opened this issue 1 week ago • 4 comments

This PR modifies the L1 emulator code for the topological trigger. The revised model uses 'hwQual' as well as etaAtVtx and phiAtVtx as input features (see PR #2 This PR adds the preprocessing of these input features to the L1 emulator code.

Very well agreement between emulator output score and qkeras model score:

validation

LukasEbeling avatar Dec 12 '25 14:12 LukasEbeling

cms-bot internal usage

cmsbuild avatar Dec 12 '25 14:12 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49620/47157

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49620/47157/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49620/47157/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Dec 12 '25 14:12 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49620/47158

cmsbuild avatar Dec 12 '25 14:12 cmsbuild

Pull request #49620 was updated.

cmsbuild avatar Dec 12 '25 14:12 cmsbuild

@cmsbuild, please test

mmusich avatar Dec 16 '25 09:12 mmusich

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0d83d/49997/summary.html COMMIT: c7211bad77594ebc9015ac6ecf2a92dbbd757128 CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49620/49997/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280229
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280203
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 16 '25 11:12 cmsbuild

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

cmsbuild avatar Dec 18 '25 13:12 cmsbuild

A new Pull Request was created by @LukasEbeling for master.

It involves the following packages:

  • L1Trigger/L1TGlobal (l1)

@BenjaminRS, @quinnanm can you please review it and eventually sign? Thanks. @Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 18 '25 13:12 cmsbuild

Can you please comment on and confirm when the updated model is able to be correctly parsed by this update? Thanks

quinnanm avatar Dec 18 '25 21:12 quinnanm