cms-sw
Fix HGCAL EM scale factor application
PR description:
This PR:
- fixes a bug in the calibration of the HGCAL RecHits, for which a scale factor obtained from config file was used directly as a multiplicative factor, whereas its reciprocal should be used;
- throws an exception if the SF from config is not positive;
- removes an unnecessary averaging over consecutive dEdx values (still taken from the same config file), since they are provided already averaged.
PR validation:
Validated by reprocessing 2025 HGCAL test beam data. The results we obtain are as expected.
@fabio-mon @pfs
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49608/47143
A new Pull Request was created by @RSalvatico for master.
It involves the following packages:
- RecoLocalCalo/HGCalRecAlgos (reconstruction)
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. @IzaakWN, @ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
New categories assigned: hgcal-dpg
@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks
test parameters:
enable = gpu workflow = 77.0 workflow_gpu = 77.0 workflow_options_gpu = -w standard,gpu
-1
Failed Tests: RelVals-AMD_MI300X
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40e833/49905/summary.html
COMMIT: fd1935011bc016418848e36f983d3d0287f29c60
CMSSW: CMSSW_16_0_X_2025-12-11-1100/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49608/49905/install.sh to create a dev area with all the needed externals and cmssw changes.
Failed RelVals-AMD_MI300X
ERROR Running runTheMatrix for '-l 17034.402,17034.403,17034.406,17034.412,17034.422,17034.423,29834.402,29834.403,29834.404,29834.704,29834.751'
ERROR TIMEOUT
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 6 differences found in the comparisons
- Reco comparison had 4 failed jobs
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4273241
- DQMHistoTests: Total failures: 112
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4273109
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 228 log files, 199 edm output root files, 53 DQM output files
- TriggerResults: no differences found
AMD_W7900 Comparison Summary
Summary:
- You potentially added 6 lines to the logs
- Reco comparison results: 243 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 29247
- DQMHistoTests: Total nulls: 11
- DQMHistoTests: Total successes: 119597
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_H100 Comparison Summary
Summary:
- You potentially removed 13 lines from the logs
- Reco comparison results: 261 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 26855
- DQMHistoTests: Total nulls: 6
- DQMHistoTests: Total successes: 121994
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_L40S Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 228 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 34447
- DQMHistoTests: Total nulls: 8
- DQMHistoTests: Total successes: 114400
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
-1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40e833/49973/summary.html
COMMIT: fd1935011bc016418848e36f983d3d0287f29c60
CMSSW: CMSSW_16_0_X_2025-12-14-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49608/49973/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 5 differences found in the comparisons
- Reco comparison had 4 failed jobs
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4273241
- DQMHistoTests: Total failures: 74
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4273147
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 228 log files, 199 edm output root files, 53 DQM output files
- TriggerResults: no differences found
AMD_W7900 Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 219 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 34918
- DQMHistoTests: Total nulls: 2
- DQMHistoTests: Total successes: 113935
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_H100 Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 253 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 28175
- DQMHistoTests: Total nulls: 13
- DQMHistoTests: Total successes: 120667
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_L40S Comparison Summary
Summary:
- You potentially added 15 lines to the logs
- Reco comparison results: 244 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 27957
- DQMHistoTests: Total nulls: 5
- DQMHistoTests: Total successes: 120893
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_T4 Comparison Summary
Summary:
- You potentially removed 2 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 250 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 148855
- DQMHistoTests: Total failures: 27849
- DQMHistoTests: Total nulls: 10
- DQMHistoTests: Total successes: 120996
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
in the definition of the tests here: https://github.com/cms-sw/cmssw/pull/49608#issuecomment-3642551258 does the bot need the parameters indented or is it ok as is?
in the definition of the tests here: #49608 (comment) does the bot need the parameters indented or is it ok as is?
I believe it is OK @pfs since GPU tests and wf 77.0 are being run
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40e833/49994/summary.html
COMMIT: fd1935011bc016418848e36f983d3d0287f29c60
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
Additional Tests: GPU,AMD_MI300X,AMD_W7900,NVIDIA_H100,NVIDIA_L40S,NVIDIA_T4
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49608/49994/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 9 differences found in the comparisons
- Reco comparison had 4 failed jobs
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4280229
- DQMHistoTests: Total failures: 41
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4280168
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 228 log files, 199 edm output root files, 53 DQM output files
- TriggerResults: no differences found
AMD_MI300X Comparison Summary
Summary:
- You potentially removed 3 lines from the logs
- Reco comparison results: 245 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 149371
- DQMHistoTests: Total failures: 30044
- DQMHistoTests: Total nulls: 10
- DQMHistoTests: Total successes: 119317
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
AMD_W7900 Comparison Summary
Summary:
- You potentially removed 20 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 222 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 149371
- DQMHistoTests: Total failures: 33474
- DQMHistoTests: Total nulls: 10
- DQMHistoTests: Total successes: 115887
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_H100 Comparison Summary
Summary:
- You potentially added 8 lines to the logs
- Reco comparison results: 226 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 149371
- DQMHistoTests: Total failures: 34675
- DQMHistoTests: Total nulls: 9
- DQMHistoTests: Total successes: 114687
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_L40S Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 228 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 149371
- DQMHistoTests: Total failures: 37151
- DQMHistoTests: Total nulls: 5
- DQMHistoTests: Total successes: 112215
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
NVIDIA_T4 Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 240 differences found in the comparisons
- Reco comparison had 6 failed jobs
- DQMHistoTests: Total files compared: 11
- DQMHistoTests: Total histograms compared: 149371
- DQMHistoTests: Total failures: 28657
- DQMHistoTests: Total nulls: 8
- DQMHistoTests: Total successes: 120706
- DQMHistoTests: Total skipped: 0
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
- Checked 43 log files, 46 edm output root files, 11 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
