cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[15_1_X] Extend MC list in prunedGenParticles for HIN analyses

Open stahlleiton opened this issue 2 weeks ago • 14 comments

PR description:

Backport of https://github.com/cms-sw/cmssw/pull/49561

@Legoinha

PR validation:

Tested with relval 160

stahlleiton avatar Dec 11 '25 15:12 stahlleiton

A new Pull Request was created by @stahlleiton for CMSSW_15_1_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@Moanwar, @battibass, @cmsbuild, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. @AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @pavlo-kashko, @philippgadow, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

cms-bot internal usage

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 15_1_X in this case?

jfernan2 avatar Dec 11 '25 17:12 jfernan2

please test

jfernan2 avatar Dec 11 '25 17:12 jfernan2

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 15_1_X in this case?

The reason is because it is needed for 2023 PbPb MC production (13_2_X) and pp reference MC production (14_1_X), and I had the impression that the policy was to include intermediate releases

stahlleiton avatar Dec 11 '25 17:12 stahlleiton

If we don't need to backport to intermediate releases (e.g. between the target and master) then I can close the PRs for the targets that are not directly needed (e.g. all except 13_2_X, 14_1_X and 15_1_X)

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 15_1_X in this case?

The reason is because it is needed for 2023 PbPb MC production (13_2_X) and pp reference MC production (14_1_X), and I had the impression that the policy was to include intermediate releases

stahlleiton avatar Dec 11 '25 17:12 stahlleiton

@cms-sw/orp-l2 could you guide us?

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 15_1_X in this case?

The reason is because it is needed for 2023 PbPb MC production (13_2_X) and pp reference MC production (14_1_X), and I had the impression that the policy was to include intermediate releases

jfernan2 avatar Dec 11 '25 18:12 jfernan2

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-120e6f/49910/summary.html COMMIT: 5884bc942ec0bfb64ab9b894279293cf409dd43e CMSSW: CMSSW_15_1_X_2025-12-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49604/49910/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 12 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 25
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4124002
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 11 '25 19:12 cmsbuild

+1

jfernan2 avatar Dec 12 '25 10:12 jfernan2

enable nano

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

please test

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-120e6f/49957/summary.html COMMIT: 5884bc942ec0bfb64ab9b894279293cf409dd43e CMSSW: CMSSW_15_1_X_2025-12-13-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49604/49957/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123957
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.085 3.085 0.000 ( +0.0% ) 3.84 3.64 +5.7% 2.674 2.608
NANOmc106Xul17v2 2500.0002 3.144 3.144 0.000 ( +0.0% ) 3.61 3.45 +4.8% 3.116 3.070
NANOmc106Xul18v2 2500.0003 3.097 3.097 0.000 ( +0.0% ) 3.68 3.50 +5.1% 3.085 3.047
NANOdata106Xul16v2 2500.0101 1.539 1.539 0.000 ( +0.0% ) 6.41 6.18 +3.6% 2.659 2.748
NANOdata106Xul17v2 2500.0102 1.925 1.925 0.000 ( +0.0% ) 4.25 4.11 +3.5% 2.840 2.862
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 5.10 4.90 +4.0% 2.749 2.800
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.83 1.39 +31.7% 2.590 2.596
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.76 1.76 +0.1% 2.581 2.587
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.54 1.53 +0.1% 2.547 2.555
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.41 1.40 +1.1% 2.717 2.718
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.63 1.53 +7.0% 2.669 2.685
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.61 1.55 +4.1% 2.594 2.618
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.53 1.50 +1.7% 2.694 2.701
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.52 1.51 +0.8% 2.678 2.702
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 4.43 4.20 +5.3% 2.985 2.977
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 6.68 6.31 +5.9% 2.716 2.689
ScoutingNANOdata124Xrun3 2500.1301 0.771 0.771 0.000 ( +0.0% ) 34.24 33.09 +3.5% 1.536 1.655
ScoutingNANOmonitordata124Xrun3 2500.1302 0.862 0.862 0.000 ( +0.0% ) 11.95 11.81 +1.1% 1.511 1.508
ScoutingNANOdata130Xrun3 2500.1303 1.250 1.250 0.000 ( +0.0% ) 25.02 24.70 +1.3% 1.524 1.636
ScoutingNANOmonitordata130Xrun3 2500.1304 1.296 1.296 0.000 ( +0.0% ) 9.17 9.02 +1.7% 1.452 1.514
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 5.73 5.49 +4.3% 2.049 2.097
EGMNANOmc140X 2500.2202 3.849 3.849 0.000 ( +0.0% ) 4.11 3.99 +2.8% 2.341 2.378
BTVNANOmc140X 2500.2203 10.466 10.466 0.000 ( +0.0% ) 2.61 2.47 +5.8% 2.533 2.545
jmeNANOmc140X 2500.2204 6.630 6.630 0.000 ( +0.0% ) 1.16 1.10 +5.9% 2.433 2.436
lepTrackInfoNANOmc140X 2500.2206 3.543 3.543 0.000 ( +0.0% ) 4.09 3.95 +3.5% 2.347 2.399
ScoutingNANOmc140X 2500.2207 1.486 1.486 0.000 ( +0.0% ) 16.06 15.49 +3.7% 1.856 1.949
ScoutingNANOwithPromptmc140X 2500.2208 4.450 4.450 0.000 ( +0.0% ) 3.45 3.32 +3.8% 2.829 2.795
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 8.01 7.71 +4.0% 2.340 2.365
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.84 5.59 +4.4% 2.602 2.621
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.73 3.64 +2.6% 2.784 2.846
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.50 1.43 +4.9% 2.686 2.741
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.89 5.54 +6.4% 2.605 2.628
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 30.04 29.12 +3.2% 1.620 1.590
ScoutingNANOmonitordata140Xrun3 2500.2308 2.783 2.783 0.000 ( +0.0% ) 5.17 5.00 +3.4% 2.928 3.058
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.783 2.783 0.000 ( +0.0% ) 5.17 5.02 +3.2% 2.935 2.991
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 46.31 45.66 +1.4% 0.694 0.692
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 3.97 3.95 +0.6% 0.838 0.840
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 8.19 7.01 +16.8% 1.789 1.786
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.73 1.66 +4.1% 1.639 1.641
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 13.42 13.26 +1.2% 1.186 1.269
hcalDPGNANO140Xrun3 2500.2404 486.016 486.016 0.000 ( +0.0% ) 1.15 1.14 +0.7% 1.627 1.640
hcalDPGCalibNANO140Xrun3 2500.2405 826.413 826.413 0.000 ( +0.0% ) 1.54 1.51 +1.7% 1.607 1.657
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.66 1.65 +0.4% 1.678 1.680
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.92 1.90 +1.1% 2.648 2.665
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.93 1.87 +3.2% 2.617 2.621
NANOmc150X 2500.3001 3.217 3.217 0.000 ( +0.0% ) 18.87 18.16 +3.9% 2.720 2.715
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 36.56 33.97 +7.6% 2.213 2.205
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 29.04 28.02 +3.6% 2.519 2.538
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 17.09 16.80 +1.7% 2.400 2.527
EGMNANOmc150X 2500.3202 4.111 4.111 0.000 ( +0.0% ) 15.41 14.91 +3.3% 2.482 2.542
BTVNANOmc150X 2500.3203 10.552 10.552 0.000 ( +0.0% ) 5.05 4.86 +4.0% 2.646 2.640
jmeNANOmc150X 2500.3204 6.595 6.595 0.000 ( +0.0% ) 1.39 1.37 +1.8% 2.608 2.832
jmeNANOrePuppimc150X 2500.3205 6.598 6.598 0.000 ( +0.0% ) 1.30 1.26 +3.3% 2.906 2.961
lepTrackInfoNANOmc150X 2500.3206 3.721 3.721 0.000 ( +0.0% ) 16.00 15.50 +3.2% 2.441 2.466
ScoutingNANOmc150X 2500.3207 1.562 1.562 0.000 ( +0.0% ) 19.65 19.30 +1.8% 2.350 2.409
ScoutingNANOwithPromptmc150X 2500.3208 4.774 4.774 0.000 ( +0.0% ) 10.78 10.51 +2.6% 2.740 2.729
BPHNANOmc150X 2500.3209 4.127 4.127 0.000 ( +0.0% ) 17.72 17.23 +2.8% 2.610 2.712
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 30.31 29.78 +1.8% 2.069 2.310
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 26.55 25.90 +2.5% 2.126 2.382
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 6.09 5.91 +3.1% 2.339 2.615
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.72 1.63 +5.4% 2.427 2.309
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.46 1.40 +4.1% 2.574 2.579
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 28.57 27.19 +5.1% 2.150 2.223
ScoutingNANOdata150Xrun3 2500.3307 1.737 1.737 0.000 ( +0.0% ) 31.93 31.06 +2.8% 1.498 1.516
ScoutingNANOmonitordata150Xrun3 2500.3308 1.398 1.398 0.000 ( +0.0% ) 26.16 25.13 +4.1% 2.183 2.166
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.601 2.601 0.000 ( +0.0% ) 18.23 17.80 +2.4% 2.470 2.502
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 36.24 34.09 +6.3% 2.400 2.283
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 34.45 32.54 +5.8% 1.775 1.887
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 33.31 32.51 +2.5% 1.427 1.478
DYToLL_M-50_13TeV_pythia8 2500.9101 14.345 14.345 0.000 ( +0.0% ) 8.65 6.04 +43.1% 1.098 1.099
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.171 0.310 -0.139 ( -44.8% ) 3.52 3.37 +4.3% 0.855 0.855
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.63 2.62 +0.2% 0.860 0.859

NANO Comparison Summary

Summary:

  • You potentially removed 996 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 97320
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 97320
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 148 log files, 87 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 13 '25 15:12 cmsbuild

+xpog

ftorrresd avatar Dec 13 '25 21:12 ftorrresd

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 13 '25 21:12 cmsbuild

+1

mandrenguyen avatar Dec 16 '25 09:12 mandrenguyen