cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[13_2_X] Extend MC list in prunedGenParticles for HIN analyses

Open stahlleiton opened this issue 2 weeks ago • 10 comments

PR description:

Backport of https://github.com/cms-sw/cmssw/pull/49561

@Legoinha

The ppRef_2024 era change had to be removed in this backport because this era modifier does not exist in this release.

PR validation:

Tested with relval 160

stahlleiton avatar Dec 11 '25 15:12 stahlleiton

A new Pull Request was created by @stahlleiton for CMSSW_13_2_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@Moanwar, @battibass, @cmsbuild, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. @AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @pavlo-kashko, @philippgadow, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

cms-bot internal usage

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

please test

jfernan2 avatar Dec 12 '25 10:12 jfernan2

+1

Size: This PR adds an extra 1800KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697d04/49925/summary.html COMMIT: c9e9e36edb1a48f2c878e0d569e2cf7355237ba9 CMSSW: CMSSW_13_2_X_2025-12-07-0000/el8_amd64_gcc11 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49603/49925/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 12 '25 11:12 cmsbuild

+1

jfernan2 avatar Dec 12 '25 11:12 jfernan2

enable nano

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

please test

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

+1

Size: This PR adds an extra 1800KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-697d04/49956/summary.html COMMIT: c9e9e36edb1a48f2c878e0d569e2cf7355237ba9 CMSSW: CMSSW_13_2_X_2025-12-07-0000/el8_amd64_gcc11 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49603/49956/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198805
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul17v2 2.629 2.629 0.000 ( +0.0% ) 8.99 8.85 +1.6% 2.544 2.548
2500.002_NANOmc106Xul18v2 2.538 2.538 0.000 ( +0.0% ) 9.34 9.85 -5.2% 2.528 2.533
2500.011_NANOdata106Xul17v2 1.642 1.642 0.000 ( +0.0% ) 10.17 9.89 +2.8% 2.428 2.432
2500.012_NANOdata106Xul18v2 1.522 1.522 0.000 ( +0.0% ) 14.39 15.35 -6.2% 2.326 2.330
2500.01_NANOdata106Xul16v2 1.271 1.271 0.000 ( +0.0% ) 18.49 19.05 -2.9% 2.231 2.232
2500.0_NANOmc106Xul16v2 2.483 2.483 0.000 ( +0.0% ) 10.02 10.60 -5.5% 2.113 2.114
2500.1_NANOmc122Xrun3 2.198 2.198 0.000 ( +0.0% ) 10.11 10.64 -5.0% 1.972 1.975
2500.211_NANOdata124Xrun3 1.545 1.545 0.000 ( +0.0% ) 7.43 5.32 +39.7% 2.269 2.260
2500.21_NANOdata124Xrun3 1.184 1.184 0.000 ( +0.0% ) 8.45 8.48 -0.3% 2.184 2.183
2500.2_NANOmc124Xrun3 2.309 2.309 0.000 ( +0.0% ) 11.73 12.33 -4.9% 1.894 1.886
2500.311_NANOdata130Xrun3 1.643 1.643 0.000 ( +0.0% ) 26.70 19.92 +34.1% 2.346 2.344
2500.31_NANOdata130Xrun3 1.258 1.258 0.000 ( +0.0% ) 37.29 41.39 -9.9% 2.283 2.277
2500.3_NANOmc130X 2.063 2.063 0.000 ( +0.0% ) 24.29 24.02 +1.1% 1.869 1.865
2500.4_NANOmc132X 2.063 2.063 0.000 ( +0.0% ) 24.17 26.54 -8.9% 1.869 1.868

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15911
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15911
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

cmsbuild avatar Dec 13 '25 14:12 cmsbuild

+xpog

ftorrresd avatar Dec 13 '25 21:12 ftorrresd

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 13 '25 21:12 cmsbuild