cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[13_3_X] Extend MC list in prunedGenParticles for HIN analyses

Open stahlleiton opened this issue 2 weeks ago • 12 comments

PR description:

Backport of https://github.com/cms-sw/cmssw/pull/49561

@Legoinha

The ppRef_2024 era change had to be removed in this backport because this era modifier does not exist in this release.

PR validation:

Tested with relval 160

stahlleiton avatar Dec 11 '25 15:12 stahlleiton

A new Pull Request was created by @stahlleiton for CMSSW_13_3_X.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction, xpog)

@Moanwar, @battibass, @cmsbuild, @ftorrresd, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks. @AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @pavlo-kashko, @philippgadow, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

cms-bot internal usage

cmsbuild avatar Dec 11 '25 15:12 cmsbuild

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 13_3_X in this case?

jfernan2 avatar Dec 11 '25 17:12 jfernan2

please test

jfernan2 avatar Dec 11 '25 17:12 jfernan2

+1

Size: This PR adds an extra 476KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e401e/49912/summary.html COMMIT: 91a8f884aae7560ca254546ea0ae8dd54799308d CMSSW: CMSSW_13_3_X_2025-12-07-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49602/49912/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 205 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3364261
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3364235
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 11 '25 19:12 cmsbuild

@stahlleiton could you explain why are we backporting to every release series? Isn't just enough the last serie, i.e. 13_3_X in this case?

This feature is needed for MC production for all 3 years of PbPb production. IIRC 2023 MC production is done in 13_2_X so @stahlleiton is backporting to all intermediate releases. I believe 13_3_X is dormant and could probably be skipped. OTOH now that the PR has been made it doesn't hurt to merge it.

mandrenguyen avatar Dec 11 '25 19:12 mandrenguyen

+1

jfernan2 avatar Dec 12 '25 10:12 jfernan2

enable nano

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

please test

ftorrresd avatar Dec 13 '25 13:12 ftorrresd

+1

Size: This PR adds an extra 476KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e401e/49955/summary.html COMMIT: 91a8f884aae7560ca254546ea0ae8dd54799308d CMSSW: CMSSW_13_3_X_2025-12-07-0000/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49602/49955/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 337 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3364261
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3364232
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001_NANOmc106Xul17v2 2.688 2.688 0.000 ( +0.0% ) 9.35 8.87 +5.4% 2.569 2.471
2500.002_NANOmc106Xul18v2 2.625 2.625 0.000 ( +0.0% ) 9.71 9.22 +5.3% 2.557 2.456
2500.011_NANOdata106Xul17v2 1.729 1.729 0.000 ( +0.0% ) 10.58 10.19 +3.9% 2.452 2.305
2500.012_NANOdata106Xul18v2 1.575 1.575 0.000 ( +0.0% ) 14.96 14.43 +3.7% 2.348 2.251
2500.01_NANOdata106Xul16v2 1.312 1.312 0.000 ( +0.0% ) 19.23 18.65 +3.1% 2.252 2.148
2500.0_NANOmc106Xul16v2 2.542 2.542 0.000 ( +0.0% ) 10.42 10.16 +2.6% 2.136 2.042
2500.1_NANOmc122Xrun3 2.190 2.190 0.000 ( +0.0% ) 10.51 10.32 +1.8% 1.995 1.895
2500.211_NANOdata124Xrun3 1.542 1.542 0.000 ( +0.0% ) 7.95 6.63 +19.9% 2.288 2.081
2500.21_NANOdata124Xrun3 1.180 1.180 0.000 ( +0.0% ) 8.70 8.22 +5.8% 2.202 2.108
2500.2_NANOmc124Xrun3 2.304 2.304 0.000 ( +0.0% ) 12.00 11.87 +1.1% 1.899 1.786
2500.311_NANOdata130Xrun3 1.642 1.642 0.000 ( +0.0% ) 27.10 16.43 +65.0% 2.370 2.154
2500.31_NANOdata130Xrun3 1.255 1.255 0.000 ( +0.0% ) 40.01 37.97 +5.4% 2.293 2.108
2500.3_NANOmc130X 2.059 2.059 0.000 ( +0.0% ) 24.50 26.09 -6.1% 1.886 1.783
2500.4_NANOmc132X 2.059 2.059 0.000 ( +0.0% ) 24.52 23.99 +2.2% 1.887 1.774
2500.5_ScoutingNanodata13X 19.575 19.575 0.000 ( +0.0% ) 2.51 0.57 +344.1% 1.291 1.076

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16405
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16405
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 34 log files, 16 edm output root files, 15 DQM output files

cmsbuild avatar Dec 13 '25 14:12 cmsbuild

+xpog

ftorrresd avatar Dec 13 '25 21:12 ftorrresd

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 13 '25 21:12 cmsbuild