[L1T] DT Trigger Phase-2 Analytical Method (AM) v2.3

[jfernan2]

PR description:

This PR implements recent changes with bug fixes and upgrades in the L1T DT Trigger Phase-2 emulator:

• Fix to DT Digis plugin from Karol Bunkowski ( @kbunkow ) which prevents crashes due to pointers to local variables stored in vectors, and then these vectors (so also the pointers) were used outside those methods

• Removed t0 Phi replacement in theta Digis at the ThetaMatching filter to preserve original t0 for the Barrel Filter objects pairing

• New DataFormat collection for DT Phase Phi-Theta matched pairs L1Phase2MuDTExtPhiThetaPair and its container L1Phase2MuDTExtPhiThetaPairContainer to be used by the Phase2 Barrel Filter

• Create new plugin DTTrigPhase2PairsProd which takes Phi and Theta DT Phase2 digi Extended collections[1] and creates a new class container of the 4 best closest Phi-Theta digi pairs per DT chamber based on the time-position phase-space distance and ordered by Phi quality. For those cases where there is no Phi/Theta partner, 4 best quality single Phi/Theta digis are saved and counterpart in pair is set to default values of the constructor digi class. [1] Requires df_extended>0 in L1Trigger/DTTriggerPhase2/plugins/DTTrigPhase2Prod.cc

• Add DT Phase Digi pair produciton to the standard L1 Trigger sequence

• Add DT Phase2 Digi and Digi pair collections to the L1 Trigger default Event Content

• General cleaning of the code

PR validation:

Local validation within CMSSW and w.r.t. firmware (w.i.p.)

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47121/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47122

[cmsbuild]

Pull request #49589 was updated.

[jfernan2]

test parameters:

• workflow = 34434.78
• relvals_opt = --what upgrade

[jfernan2]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild Size: This PR adds an extra 100KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/49878/summary.html COMMIT: ec4ff950da89db168b0e2298a3e4935cf15502b0 CMSSW: CMSSW_16_0_X_2025-12-09-2300/el8_amd64_gcc13 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49589/49878/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[jfernan2]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49589/47123

[cmsbuild]

Pull request #49589 was updated.

[cmsbuild]

+1

Size: This PR adds an extra 100KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e088c/49879/summary.html COMMIT: 773c3ac8bb2ccc611d5b420d30cea12bf4a6f0f3 CMSSW: CMSSW_16_0_X_2025-12-10-1100/el8_amd64_gcc13 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49589/49879/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 4 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 4 failed jobs
• DQMHistoTests: Total files compared: 54
• DQMHistoTests: Total histograms compared: 4411094
• DQMHistoTests: Total failures: 82
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4410992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
• Checked 232 log files, 202 edm output root files, 54 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.