cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[15_1_X] Fix LHEPtFilter default parameters

Open jsamudio opened this issue 3 weeks ago • 6 comments

PR description:

Verbatim backport of #49533 for 15_1_X. The PR which these changes now fix was initially introduced with the CMSSW_15_1_0_pre5 release.

PR validation:

Auto generated cfi looks correct. Main validation on generation done with equivalent changes for 10_6_X .

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR is #49533, this backport is needed to fix the functionality of the LHEPtFilter in the 15_1_X releases

jsamudio avatar Dec 03 '25 17:12 jsamudio

A new Pull Request was created by @jsamudio for CMSSW_15_1_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 03 '25 17:12 cmsbuild

cms-bot internal usage

cmsbuild avatar Dec 03 '25 17:12 cmsbuild

please test

lviliani avatar Dec 10 '25 14:12 lviliani

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7f67b4/49880/summary.html COMMIT: caad421a5ab3667acca430be1eccb80f1246f47e CMSSW: CMSSW_15_1_X_2025-12-10-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49540/49880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 15
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4124012
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 10 '25 16:12 cmsbuild

+generators

lviliani avatar Dec 15 '25 10:12 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 15 '25 10:12 cmsbuild

+1

ftenchini avatar Dec 22 '25 09:12 ftenchini