cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[10_6_X] Fix LHEPtFilter default parameters

Open jsamudio opened this issue 3 weeks ago • 11 comments

PR description:

This PR fixes the functionality of the LHEPtFilter which will encounter illegal parameters due to missing entries from the fillDescriptions defaults.

The exception message is:

----- Begin Fatal Exception 09-Dec-2025 13:15:04 CST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=LHEPtFilter label='LHEPtFilter'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'ptMax'
 'ptMin'
 'selectedPdgIds'
 'src'
You could be trying to use parameter names that are not
allowed for this plugin or they could be misspelled.
----- End Fatal Exception -------------------------------------------------

PR validation:

Tested in fragment fed to cmsDriver for generation in CMSSW_10_6_48_patch1. An example config is located here: https://cernbox.cern.ch/s/QKgZpKsv1r0ogHq

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport of #49533, and is intended for CMSSW_10_6_X.

jsamudio avatar Dec 02 '25 22:12 jsamudio

A new Pull Request was created by @jsamudio for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Dec 02 '25 22:12 cmsbuild

cms-bot internal usage

cmsbuild avatar Dec 02 '25 22:12 cmsbuild

Can somebody trigger a test?

hatakeyamak avatar Dec 06 '25 13:12 hatakeyamak

Perhaps somebody from generator.

hatakeyamak avatar Dec 06 '25 14:12 hatakeyamak

@jsamudio for record, maybe you can post a config with which you tested this fix with?

hatakeyamak avatar Dec 06 '25 14:12 hatakeyamak

@jsamudio for record, maybe you can post a config with which you tested this fix with?

I added some additional information to the description including a link to an example config.

jsamudio avatar Dec 09 '25 19:12 jsamudio

please test

lviliani avatar Dec 10 '25 09:12 lviliani

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221d04/49876/summary.html COMMIT: 18ac67a60a4bdc7688fe87a38ced80177c1ef1cb CMSSW: CMSSW_10_6_X_2025-12-07-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49534/49876/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Dec 10 '25 11:12 cmsbuild

Thank you @lviliani. https://github.com/cms-sw/cmssw/pull/49533 is the main PR, so it may need to be tested as well. And, another backport to 15_1_X is here: https://github.com/cms-sw/cmssw/pull/49540

hatakeyamak avatar Dec 10 '25 12:12 hatakeyamak

+generators

lviliani avatar Dec 15 '25 10:12 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 15 '25 10:12 cmsbuild