cms-sw
Fix LHEPtFilter default parameters
PR description:
This PR fixes the functionality of the LHEPtFilter which will encounter illegal parameters due to missing entries from the fillDescriptions defaults. The bad behavior was mistakenly introduced in #48505
PR validation:
Auto generated cfi looks correct. Main validation on generation done with equivalent changes for 10_6_X .
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Another PR will be opened for a backport to CMSSW_10_6_X
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49533/47045
A new Pull Request was created by @jsamudio for master.
It involves the following packages:
- GeneratorInterface/GenFilters (generators)
@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
Wouldn't this also need to be back propagated to intermediate releases?
Wouldn't this also need to be back propagated to intermediate releases?
Now that you mention it, yes. Otherwise any release containing the original changes will have this filter as broken. So this means opening a backport PR for each release between when the original changes were merged and now?
Wouldn't this also need to be back propagated to intermediate releases?
Now that you mention it, yes. Otherwise any release containing the original changes will have this filter as broken. So this means opening a backport PR for each release between when the original changes were merged and now?
Yeah
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ee46c/49881/summary.html
COMMIT: b41ae7114f6b7a7314964de54ef675602eb0222e
CMSSW: CMSSW_16_0_X_2025-12-10-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49533/49881/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 5 differences found in the comparisons
- Reco comparison had 4 failed jobs
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4273241
- DQMHistoTests: Total failures: 78
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4273143
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 227 log files, 198 edm output root files, 53 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
