cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

GenParticles2HepMC: connect orphans to beams (15_1)

Open mseidel42 opened this issue 1 month ago • 10 comments

backport of https://github.com/cms-sw/cmssw/pull/49447

mseidel42 avatar Nov 23 '25 14:11 mseidel42

A new Pull Request was created by @mseidel42 for CMSSW_15_1_X.

It involves the following packages:

  • GeneratorInterface/RivetInterface (generators)

@cmsbuild, @lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #49447

cmsbuild avatar Nov 23 '25 14:11 cmsbuild

cms-bot internal usage

cmsbuild avatar Nov 23 '25 14:11 cmsbuild

assign xpog

vlimant avatar Nov 24 '25 11:11 vlimant

enable nano

vlimant avatar Nov 24 '25 11:11 vlimant

please test

vlimant avatar Nov 24 '25 11:11 vlimant

New categories assigned: xpog

@battibass,@ftorrresd you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Nov 24 '25 11:11 cmsbuild

+1

Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-415c5a/49637/summary.html COMMIT: bd1333fd9e8c14f656fa8146aadfc1c514fae0f8 CMSSW: CMSSW_15_1_X_2025-11-24-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49446/49637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123998
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.085 3.085 0.000 ( +0.0% ) 3.27 3.23 +1.4% 2.704 2.451
NANOmc106Xul17v2 2500.0002 3.144 3.144 0.000 ( +0.0% ) 3.04 3.02 +0.7% 2.741 2.471
NANOmc106Xul18v2 2500.0003 3.097 3.097 0.000 ( +0.0% ) 3.11 3.07 +1.4% 2.745 2.491
NANOdata106Xul16v2 2500.0101 1.539 1.539 0.000 ( +0.0% ) 5.56 5.50 +1.1% 2.539 2.264
NANOdata106Xul17v2 2500.0102 1.925 1.925 0.000 ( +0.0% ) 3.69 3.66 +0.8% 2.613 2.309
NANOdata106Xul18v2 2500.0103 1.890 1.890 0.000 ( +0.0% ) 4.43 4.34 +2.2% 2.598 2.277
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.58 1.71 -7.2% 2.944 2.095
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.59 1.66 -4.5% 2.943 2.072
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.36 1.48 -7.8% 2.638 2.305
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.23 1.32 -6.8% 3.071 2.230
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.34 1.51 -11.3% 2.895 2.541
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.39 1.50 -7.3% 2.908 2.538
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.34 1.46 -8.0% 2.921 2.571
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.29 1.44 -10.9% 2.911 2.537
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 3.75 3.72 +1.0% 2.645 2.330
NANOdata130Xrun3 2500.1101 1.790 1.790 0.000 ( +0.0% ) 5.69 5.70 -0.2% 2.787 2.553
ScoutingNANOdata124Xrun3 2500.1301 0.771 0.771 0.000 ( +0.0% ) 28.77 30.73 -6.4% 1.565 1.525
ScoutingNANOmonitordata124Xrun3 2500.1302 0.862 0.862 0.000 ( +0.0% ) 10.16 10.71 -5.1% 1.448 1.419
ScoutingNANOdata130Xrun3 2500.1303 1.250 1.250 0.000 ( +0.0% ) 22.12 22.54 -1.9% 1.554 1.484
ScoutingNANOmonitordata130Xrun3 2500.1304 1.296 1.296 0.000 ( +0.0% ) 7.61 7.88 -3.4% 1.451 1.408
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 4.82 5.07 -4.9% 2.258 2.042
EGMNANOmc140X 2500.2202 3.849 3.849 0.000 ( +0.0% ) 3.47 3.62 -4.2% 2.608 2.346
BTVNANOmc140X 2500.2203 10.466 10.466 0.000 ( +0.0% ) 2.19 2.25 -2.9% 2.846 2.502
jmeNANOmc140X 2500.2204 6.630 6.630 0.000 ( +0.0% ) 1.00 0.99 +1.5% 2.693 2.385
lepTrackInfoNANOmc140X 2500.2206 3.543 3.543 0.000 ( +0.0% ) 3.57 3.47 +2.9% 2.618 2.300
ScoutingNANOmc140X 2500.2207 1.486 1.486 0.000 ( +0.0% ) 13.89 13.65 +1.8% 1.965 1.644
ScoutingNANOwithPromptmc140X 2500.2208 4.450 4.450 0.000 ( +0.0% ) 3.02 2.88 +4.6% 2.922 2.444
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 6.94 6.63 +4.6% 2.592 2.300
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 4.94 4.84 +2.2% 2.929 2.592
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.30 3.19 +3.6% 3.167 2.777
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.29 1.26 +2.4% 2.968 2.648
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.00 5.03 -0.6% 2.931 2.583
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 26.36 26.27 +0.3% 1.663 1.524
ScoutingNANOmonitordata140Xrun3 2500.2308 2.783 2.783 0.000 ( +0.0% ) 4.52 4.30 +5.0% 3.179 2.925
ScoutingNANOmonitorWithPromptdata140Xrun3 2500.2309 2.783 2.783 0.000 ( +0.0% ) 4.53 4.31 +5.2% 3.182 2.926
L1ScoutingSelectionNANOdata140Xrun3 2500.2311 0.081 0.081 0.000 ( +0.0% ) 39.96 40.20 -0.6% 0.840 0.689
L1ScoutingNANOdata140Xrun3 2500.231 0.082 0.082 0.000 ( +0.0% ) 3.53 3.47 +1.8% 0.969 0.836
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 6.27 6.12 +2.6% 1.936 1.780
muDPGNANO140Xrun3 2500.2402 10.377 10.377 0.000 ( +0.0% ) 1.48 1.49 -0.7% 1.746 1.633
muDPGNANOBkg140Xrun3 2500.2403 6.401 6.401 0.000 ( +0.0% ) 11.50 11.46 +0.3% 1.256 1.216
hcalDPGNANO140Xrun3 2500.2404 486.016 486.016 0.000 ( +0.0% ) 1.02 0.97 +5.1% 1.737 1.597
hcalDPGCalibNANO140Xrun3 2500.2405 826.413 826.413 0.000 ( +0.0% ) 1.39 1.37 +1.2% 1.707 1.567
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.48 1.49 -0.6% 1.820 1.761
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.65 1.66 -0.4% 3.052 2.676
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.69 1.66 +1.6% 2.841 2.593
NANOmc150X 2500.3001 3.217 3.217 0.000 ( +0.0% ) 15.66 15.96 -1.8% 2.721 2.636
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 30.18 29.36 +2.8% 2.458 2.198
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 25.21 23.43 +7.6% 2.547 2.365
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 14.89 13.62 +9.3% 2.606 2.356
EGMNANOmc150X 2500.3202 4.111 4.111 0.000 ( +0.0% ) 13.60 12.70 +7.1% 2.708 2.432
BTVNANOmc150X 2500.3203 10.552 10.552 0.000 ( +0.0% ) 4.29 4.13 +4.0% 2.925 2.625
jmeNANOmc150X 2500.3204 6.760 6.760 0.000 ( +0.0% ) 1.16 1.12 +3.1% 2.889 2.659
jmeNANOrePuppimc150X 2500.3205 6.763 6.763 0.000 ( +0.0% ) 1.08 1.04 +4.2% 3.163 2.935
lepTrackInfoNANOmc150X 2500.3206 3.721 3.721 0.000 ( +0.0% ) 13.86 13.89 -0.2% 2.708 2.434
ScoutingNANOmc150X 2500.3207 1.562 1.562 0.000 ( +0.0% ) 16.74 16.49 +1.5% 2.486 2.299
ScoutingNANOwithPromptmc150X 2500.3208 4.774 4.774 0.000 ( +0.0% ) 9.66 9.52 +1.5% 2.945 2.691
BPHNANOmc150X 2500.3209 4.127 4.127 0.000 ( +0.0% ) 15.32 14.35 +6.7% 2.788 2.538
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 25.62 23.05 +11.1% 2.372 2.063
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 22.99 20.41 +12.7% 2.454 2.143
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.20 5.14 +1.3% 2.682 2.502
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.44 1.36 +6.1% 2.627 2.324
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.28 1.21 +6.2% 2.609 2.593
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 19.59 22.27 -12.0% 2.457 2.133
ScoutingNANOdata150Xrun3 2500.3307 1.737 1.737 0.000 ( +0.0% ) 27.44 26.33 +4.2% 1.680 1.481
ScoutingNANOmonitordata150Xrun3 2500.3308 1.398 1.398 0.000 ( +0.0% ) 22.30 21.00 +6.2% 2.365 2.155
ScoutingNANOmonitorWithPromptdata150Xrun3 2500.3309 2.601 2.601 0.000 ( +0.0% ) 16.51 15.31 +7.8% 2.724 2.524
BPHNANOdata150Xrun3 2500.331 2.632 2.632 0.000 ( +0.0% ) 30.57 28.19 +8.4% 2.524 2.234
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 28.72 28.39 +1.2% 1.889 1.797
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 30.46 27.77 +9.7% 1.477 1.417
DYToLL_M-50_13TeV_pythia8 2500.9101 14.345 14.345 0.000 ( +0.0% ) 7.44 6.91 +7.7% 1.099 1.096
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.240 0.240 0.000 ( +0.0% ) 3.00 3.66 -18.0% 0.855 0.850
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.32 2.17 +7.0% 0.857 0.858

NANO Comparison Summary

Summary:

  • You potentially added 449 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 97320
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 97320
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 148 log files, 87 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Nov 24 '25 13:11 cmsbuild

+1

battibass avatar Nov 24 '25 15:11 battibass

+generators

lviliani avatar Dec 04 '25 15:12 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Dec 04 '25 15:12 cmsbuild