cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

ECAL - Get fill number and delivered lumi from LHCInfoPerFill - 151X

Open thomreis opened this issue 1 month ago • 11 comments

PR description:

Since the LHCInfo tag in the prompt GT is not updated after May 2024 get the fill number and delivered and recorded lumi information from LHCInfoPerFill instead for Run 3. This should fix the fill, delivLumi, and recLumi branches being set to 0 in the output ntuple for runs after May 2024.

Adds the delivLumi and recLumi fields to LHCInfoCombined.

PR validation:

With the PR the fill, delivLumi, and recLumi branches in the output ntuple are filled for 2025 runs.

This PR is a backport of #49417 to 151X to fix an issue with the automatically produced ECAL phi symmetry nanoAODs in the ongoing data taking.

thomreis avatar Nov 19 '25 11:11 thomreis

A new Pull Request was created by @thomreis for CMSSW_15_1_X.

It involves the following packages:

  • Calibration/EcalCalibAlgos (alca)

@arunhep, @atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks. @ReyerBand, @argiro, @mmusich, @rchatter, @rsreds, @thomreis, @tocheng, @wang0jin, @yuanchao this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #49417

cmsbuild avatar Nov 19 '25 11:11 cmsbuild

cms-bot internal usage

cmsbuild avatar Nov 19 '25 11:11 cmsbuild

type ecal

thomreis avatar Nov 19 '25 11:11 thomreis

backport of #49417

thomreis avatar Nov 19 '25 11:11 thomreis

please test

thomreis avatar Nov 19 '25 15:11 thomreis

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-921e0d/49556/summary.html COMMIT: 9c54da53f3ceba91ad196aa5673cb0a1fe0bd1ba CMSSW: CMSSW_15_1_X_2025-11-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49418/49556/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4124027
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Nov 19 '25 18:11 cmsbuild

Pull request #49418 was updated. @Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @perrotta can you please check and sign again.

cmsbuild avatar Nov 27 '25 16:11 cmsbuild

please test

thomreis avatar Nov 27 '25 16:11 thomreis

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-921e0d/49722/summary.html COMMIT: fa42d9c4a546f7e034af9b9ee85aab5e5dd3f4db CMSSW: CMSSW_15_1_X_2025-11-27-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49418/49722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • Reco comparison had 2 failed jobs
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4124047
  • DQMHistoTests: Total failures: 53
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4123974
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Nov 27 '25 19:11 cmsbuild

+1

  • Verbatim backport of #49417

perrotta avatar Nov 30 '25 08:11 perrotta

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Nov 30 '25 08:11 cmsbuild