cms-sw
W3Pi Emulation and Test Vectors
PR description:
The TkTriplet word is updated to contain a valid bit, triplet pT, eta, and phi fields (which are currently set to 0), a triplet invariant mass field, the three triplet track pTs, and an unassigned field. The new word spans 97 bits, and is padded with zeroes to span 128 bits (evenly spanning two 64-bit link data words). The tktriplet emulation plugin finds the three highest pT tracks in an event, computes the invariant mass from them, and fills the output word with the aforementioned nonzero fields.
https://indico.cern.ch/event/1588031/
- See the above indico page for a talk regarding the W->3pi updates
PR validation:
Tests have been done to ensure that the output tktriplet word is correctly written in APX board format. The word currently spans the first two 64-bit link words of each event on link 2, and tests using HLS firmware have shown that the invariant mass and triplet track pT fields can be correctly decoded from the test vectors.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49003/46197
A new Pull Request was created by @Jared-Fraticelli for master.
It involves the following packages:
- DataFormats/L1Trigger (l1)
- L1Trigger/DemonstratorTools (l1)
- L1Trigger/L1TTrackMatch (upgrade, l1)
@BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well. @ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e554af/48361/summary.html
COMMIT: 6027c5ebffd549b6b545b79cd3308a7807581b94
CMSSW: CMSSW_16_0_X_2025-09-29-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49003/48361/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 4 differences found in the comparisons
- DQMHistoTests: Total files compared: 52
- DQMHistoTests: Total histograms compared: 4058318
- DQMHistoTests: Total failures: 23
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4058275
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
- Checked 223 log files, 192 edm output root files, 52 DQM output files
- TriggerResults: no differences found
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49003/46673
Pull request #49003 was updated. @BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @subirsarkar can you please check and sign again.
The new push has updated files implementing the comments from above.
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e554af/49460/summary.html
COMMIT: df2d63ee2fb94de5e21b13af59ae9b4f88e1f263
CMSSW: CMSSW_16_0_X_2025-11-13-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49003/49460/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 4 lines from the logs
- ROOTFileChecks: Some differences in event products or their sizes found
- Reco comparison results: 8 differences found in the comparisons
- Reco comparison had 2 failed jobs
- DQMHistoTests: Total files compared: 52
- DQMHistoTests: Total histograms compared: 4017324
- DQMHistoTests: Total failures: 38
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4017266
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
- Checked 223 log files, 192 edm output root files, 52 DQM output files
- TriggerResults: no differences found
Hello, I think I addressed all of the commented feedback with this most recent push. Please let me know if there's anything else that should be addressed. Thank you!
Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.