cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Modifications for Pythia 8.315

Open mseidel42 opened this issue 6 months ago • 3 comments

PR description:

Needs https://github.com/cms-sw/cmsdist/pull/9612

Pythia 8.315 requires

  • ParticleDecays:allowPhotonRadiation -> HadronLevel:QED

PR validation:

Pass    6s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareIdentical
Pass    8s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareExternal
Pass   12s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8InterfaceCompareExternalStreams
Pass   33s ... GeneratorInterface/Pythia8Interface/TestGeneratorInterfacePythia8ConcurrentGeneratorFilter
Pass   26s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_bplus
Pass   14s ... GeneratorInterface/Pythia8Interface/testGeneratorInterfacePythia8InterfaceTP
Pass   28s ... GeneratorInterface/EvtGenInterface/TestGeneratorInterfaceEvtGenInterface_external_bplus
Pass   72s ... GeneratorInterface/EvtGenInterface/GeneratorInterfaceEvtGenInterfaceTest
Pass  870s ... TauAnalysis/MCEmbeddingTools/testTauEmbeddingWorkflow2016preVFP
Pass  901s ... TauAnalysis/MCEmbeddingTools/testTauEmbeddingWorkflow2017
Pass  965s ... TauAnalysis/MCEmbeddingTools/testTauEmbeddingWorkflow2016postVFP
Pass 1529s ... TauAnalysis/MCEmbeddingTools/testTauEmbeddingWorkflow2018                                                                                         
Pass 1619s ... TauAnalysis/MCEmbeddingTools/testTauEmbeddingWorkflow2022postEE
>> Test sequence completed for CMSSW CMSSW_15_1_X_2025-06-25-2300  

mseidel42 avatar Jun 26 '25 11:06 mseidel42

cms-bot internal usage

cmsbuild avatar Jun 26 '25 11:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48422/45322

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/Generator/python/Pythia8CommonSettings_cfi.py modified in PR(s): #47092
    • File Configuration/Generator/python/UpsMM_8TeV_TuneCUETP8M1_cfi.py modified in PR(s): #47092
    • File Configuration/Generator/python/bJpsiX_8TeV_TuneCUETP8M1_cfi.py modified in PR(s): #47092
    • File GeneratorInterface/EvtGenInterface/plugins/test/Py8_lambadb_evtgen1_Lb2plnuLCSR_cfg.py modified in PR(s): #47092
    • File GeneratorInterface/EvtGenInterface/test/Py8_bplus_evtgen1_cfg.py modified in PR(s): #47092
    • File GeneratorInterface/EvtGenInterface/test/external_Py8_bplus_evtgen1_cfg.py modified in PR(s): #47092
    • File GeneratorInterface/PhotosInterface/test/DY_7TeV_pythia8_rivet.py modified in PR(s): #47092
    • File GeneratorInterface/Pythia8Interface/test/FXFXewk_test.py modified in PR(s): #47092
    • File GeneratorInterface/Pythia8Interface/test/ZToTauTau_photos_13TeV_rivet_cfg.py modified in PR(s): #47092
    • File GeneratorInterface/Pythia8Interface/test/test_Pythia8ConcurrentGeneratorFilter_WZ_TuneCP5_13TeV-pythia8.sh modified in PR(s): #47092

cmsbuild avatar Jun 26 '25 11:06 cmsbuild

A new Pull Request was created by @mseidel42 for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • GeneratorInterface/EvtGenInterface (generators)
  • GeneratorInterface/PhotosInterface (generators)
  • GeneratorInterface/Pythia8Interface (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @Martin-Grunewald, @alberto-sanchez, @fabiocos, @missirol, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 26 '25 11:06 cmsbuild

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

cmsbuild avatar Sep 10 '25 06:09 cmsbuild

+1 tested with https://github.com/cms-sw/cmsdist/pull/9943

mandrenguyen avatar Oct 01 '25 06:10 mandrenguyen

hold See discussion here: https://github.com/cms-sw/cmsdist/pull/9943

mandrenguyen avatar Oct 01 '25 11:10 mandrenguyen

Pull request has been put on hold by @mandrenguyen They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild avatar Oct 01 '25 11:10 cmsbuild

+generators

lviliani avatar Oct 03 '25 10:10 lviliani

REMINDER @mandrenguyen, @sextonkennedy, @ftenchini: This PR was tested with cms-sw/cmsdist#9943, please check if they should be merged together

cmsbuild avatar Oct 03 '25 11:10 cmsbuild

unhold

mandrenguyen avatar Oct 03 '25 11:10 mandrenguyen

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

cmsbuild avatar Oct 03 '25 11:10 cmsbuild

merge tested with https://github.com/cms-sw/cmsdist/pull/9943

mandrenguyen avatar Oct 03 '25 11:10 mandrenguyen