cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

adds Heavy Ion initialization to Pythia [15_0_X]

Open michael-pitt opened this issue 6 months ago • 4 comments

PR description:

This PR allows initiating the Pythia event generator with ions. The fragment should contain:

generator = cms.EDFilter("Pythia8ConcurrentGeneratorFilter",
   ...
   HeavyIonInitialState = cms.PSet(),
   ...
)

and the user can set up Beams:idA and Beams:idB manually.

PR validation:

Validated with CMSSW_15_0_X

michael-pitt avatar Jun 25 '25 17:06 michael-pitt

A new Pull Request was created by @michael-pitt for CMSSW_15_0_X.

It involves the following packages:

  • GeneratorInterface/Pythia8Interface (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 25 '25 17:06 cmsbuild

cms-bot internal usage

cmsbuild avatar Jun 25 '25 17:06 cmsbuild

@michael-pitt The usual paradigm is to make a PR to the master release and backport. Is there a reason to do otherwise?

mandrenguyen avatar Jun 25 '25 17:06 mandrenguyen

@michael-pitt The usual paradigm is to make a PR to the master release and backport. Is there a reason to do otherwise?

Yes, you are right, I made the PR to the master now (https://github.com/cms-sw/cmssw/pull/48414) I thought it will go faster to 15_0_X this way....

michael-pitt avatar Jun 25 '25 18:06 michael-pitt

please test

mandrenguyen avatar Jul 08 '25 07:07 mandrenguyen

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4df09b/47126/summary.html COMMIT: d1c6faa47b8f59f4dca7835bc27bd848048a213c CMSSW: CMSSW_15_0_X_2025-07-07-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48412/47126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4011390
  • DQMHistoTests: Total failures: 76
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4011294
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 1 / 48 workflows

cmsbuild avatar Jul 08 '25 10:07 cmsbuild

@cms-sw/generators-l2 Can you sign please? thanks

stahlleiton avatar Jul 09 '25 16:07 stahlleiton

+1

lviliani avatar Jul 10 '25 08:07 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 10 '25 08:07 cmsbuild

+1

mandrenguyen avatar Jul 10 '25 12:07 mandrenguyen