cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[15.0.X] Strip overlap check for different product ID

Open mmasciov opened this issue 6 months ago • 6 comments

PR description:

Backport of https://github.com/cms-sw/cmssw/pull/48403

As per title. The possibility to produce strip clusters with different algorithm was discussed in https://its.cern.ch/jira/browse/CMSHLT-3534 for HLT in 2025-2026. As other developments are in the pipeline, this possibility is currently on hold. However, it would not be technically possible without this PR. In fact, this PR introduces the possibility to check strip overlaps for different product IDs. This is fully transparent for the current HLT scenario, as well as for offline (see below).

PR validation:

HLT tracking: https://uaf-10.t2.ucsd.edu/~mmasciov/TRKPOG/HLT2025/HLT_TTbarPU_TrackListMergerTest_mkFitDR/plots_hlt.html Offline tracking: https://uaf-10.t2.ucsd.edu/~mmasciov/TRKPOG/HLT2025/MTVOffline_TTbarPU_TrackListMergerTest/

Offline tracking timing is also NOT affected: https://uaf-10.t2.ucsd.edu/~mmasciov/TRKPOG/HLT2025/MTVOffline_TTbarPU_TrackListMergerTest/plots_timing.html

FYI, @cms-sw/tracking-pog-l2, @slava77

mmasciov avatar Jun 25 '25 12:06 mmasciov

A new Pull Request was created by @mmasciov for CMSSW_15_0_X.

It involves the following packages:

  • DataFormats/TrackerRecHit2D (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. @VinInn, @VourMa, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #48403

cmsbuild avatar Jun 25 '25 12:06 cmsbuild

cms-bot internal usage

cmsbuild avatar Jun 25 '25 12:06 cmsbuild

please test

jfernan2 avatar Jun 25 '25 15:06 jfernan2

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8d8d0/46914/summary.html COMMIT: 0a8bcce3a13afead380221c8b5e0983119a2a9c6 CMSSW: CMSSW_15_0_X_2025-06-25-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48404/46914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Jun 25 '25 18:06 cmsbuild

+1

jfernan2 avatar Jun 26 '25 07:06 jfernan2

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jun 26 '25 07:06 cmsbuild

@cms-sw/tracking-pog-l2

As other developments are in the pipeline, this possibility is currently on hold.

I'd like to have clarified if tracking POG considers this PR necessary or not for a possible update of the 2025 HLT data-taking menu (see ticket CMSHLT-3534) in V1.3 (deadline for tickets Jul 23rd). Said in other words, shall we strive to have it in the next release?

mmusich avatar Jul 01 '25 13:07 mmusich

@cms-sw/tracking-pog-l2

As other developments are in the pipeline, this possibility is currently on hold.

I'd like to have clarified if tracking POG considers this PR necessary or not for a possible update of the 2025 HLT data-taking menu (see ticket CMSHLT-3534) in V1.3 (deadline for tickets Jul 23rd). Said in other words, shall we strive to have it in the next release?

If PR #47629 is not in (the PR is under review; using #47629 would be the best scenario for the Tracking POG), then the strategy depicted in https://its.cern.ch/jira/browse/CMSHLT-3534 should be considered, and for that this PR is required. As the PR doesn't have any impact on physics as is, is there a reason not to have this in the release?

mmasciov avatar Jul 01 '25 13:07 mmasciov

As the PR doesn't have any impact on physics as is, is there a reason not to have this in the release?

on the contrary, I am intending to push it.

mmusich avatar Jul 01 '25 13:07 mmusich

The impact of this PR on the throughput of the current Run-3 HLT menu was checked, and found to be small. More info can be found in CMSHLT-3534 (comment).

missirol avatar Jul 06 '25 12:07 missirol

+1

mandrenguyen avatar Jul 07 '25 15:07 mandrenguyen

backport of https://github.com/cms-sw/cmssw/pull/48403

mandrenguyen avatar Jul 07 '25 15:07 mandrenguyen