cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Add L1Ntuple customisation for HLTScouting

Open artlbv opened this issue 6 months ago • 5 comments

PR description:

This adds a customisation for the L1Ntuples to run on HLTSCOUT data which just stores the L1 uGT collection in it's RAW format hltFEDSelectorL1. I'm reusing the L1NtupleNanoDST setup but adding the unpacking of the gtStage2Digis into the sequence, hence I had to introduce a new customiser: L1NtupleHLTSCOUT.

PR validation:

Tested in CMSSW_15_1_0_pre3 with:

cmsDriver.py l1NtupleFromHLTScout -s NONE -n 1000 --no_output \
--era=Run3 --data --conditions=150X_dataRun3_HLT_v1  \
--customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleHLTSCOUT \
--filein file:/eos/cms/tier0/store/data/Run2025C/ScoutingPFRun3/HLTSCOUT/v1/000/393/515/00000/0037f433-1c58-4071-91f0-f2ae428ba870.root 

Which successfully produces a L1Ntuple.root file with the trees being properly filled for the unpacked L1 objects and uGT decisions.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not planned, except if considered useful by the L1 DPG et al.

artlbv avatar Jun 24 '25 12:06 artlbv

cms-bot internal usage

cmsbuild avatar Jun 24 '25 12:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48395/45290

cmsbuild avatar Jun 24 '25 12:06 cmsbuild

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • L1Trigger/L1TNtuples (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks. @Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 24 '25 12:06 cmsbuild

please test

quinnanm avatar Jun 24 '25 23:06 quinnanm

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc5e91/46907/summary.html COMMIT: ba9c5559ba03c91d8a4447273c81037fccc5ca0f CMSSW: CMSSW_15_1_X_2025-06-24-1800/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48395/46907/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4058157
  • DQMHistoTests: Total failures: 97
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4058040
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 25 '25 02:06 cmsbuild

can this PR be merged?

artlbv avatar Jul 14 '25 09:07 artlbv

+l1

quinnanm avatar Jul 26 '25 03:07 quinnanm

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 26 '25 03:07 cmsbuild

+1

mandrenguyen avatar Jul 26 '25 10:07 mandrenguyen