cms-sw
Updated to use __getitem__
This PR replaces the legacy Pythonization of TDirectory via getattr, which allowed object access like my_file.my_tree. As of ROOT 6.32, this behavior has been deprecated in favor of explicit item-getting using getitem, e.g., my_file["my_tree"]. https://github.com/root-project/root/pull/19096
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48393/45287
A new Pull Request was created by @akritkbehera for master.
It involves the following packages:
- DQMServices/Demo (dqm)
- DQMServices/FwkIO (dqm)
@antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please review it and eventually sign? Thanks. @barvic this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
@akritkbehera , can you please update the description why this was needed?
+1
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bda2d/46884/summary.html
COMMIT: 77812f761eadafa1a301ed0fd4ec992f3a6eac72
CMSSW: CMSSW_15_1_X_2025-06-23-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48393/46884/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 2 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4058157
- DQMHistoTests: Total failures: 34
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4058103
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
please test for CMSSW_15_1_ROOT6_X
lets test is against latest ROOT6 IBs where this was failing https://github.com/cms-sw/cmsdist/pull/9939#issuecomment-2996396062
-1
Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bda2d/46901/summary.html
COMMIT: 77812f761eadafa1a301ed0fd4ec992f3a6eac72
CMSSW: CMSSW_15_1_ROOT6_X_2025-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48393/46901/install.sh to create a dev area with all the needed externals and cmssw changes.
Unit Tests
I found 2 errors in the following unit tests:
---> test TestDQMServicesDemo had ERRORS ---> test TestDQMGUIUpload had ERRORS
Comparison Summary
Summary:
- You potentially added 34 lines to the logs
- Reco comparison results: 1055 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4058157
- DQMHistoTests: Total failures: 968
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4057169
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
@akritkbehera , looks like https://github.com/cms-sw/cmssw/blob/master/DQMServices/Demo/test/dqmiodumpentries.py also hasused getattr in couple of places. You can create ROOT6_X based devel area, check out DQMServices/Demo , build it and then run scram build runtests to see if it fixes the issue
hold see comment: https://github.com/cms-sw/cmssw/pull/48393#issuecomment-3001738586
Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48393/45299
Pull request #48393 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.
ROOT6_X unit tests passed now, so PR looks good and this should fix the 3 failing DQM tests in ROOT6 IBs. @akritkbehera , please squash these three commits
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48393/45300
Pull request #48393 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48393/45301
Pull request #48393 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.
@cms-sw/dqm-l2 , can you please review it again. @cms-sw/orp-l2 , @mandrenguyen , https://github.com/cms-sw/cmssw/pull/48393#issuecomment-3001738586 is resolved now, so you can unhold this PR. This should fix the 3 failing dqm unit tests in ROOT6 IBs
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bda2d/46912/summary.html
COMMIT: b249cc9317caa9b17999e02dfa9f83dd939cd5f8
CMSSW: CMSSW_15_1_X_2025-06-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48393/46912/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially removed 3 lines from the logs
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4065619
- DQMHistoTests: Total failures: 5
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4065594
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
@antoniovagnerini, @ctarricone, @rseidita can you please review this. This is just a technical fix needed for ROOT master updates and works also for ROOT 6.32
@cms-sw/orp-l2 , maybe dqm L2 are not around. Can we get this in for next IB so that we can move forward with ROOT6 updates. This is a trivial update ( which was already signed by dqm but due to one update the signatures were reset)
