cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Remove deprecated genParticleCandidates

Open tvami opened this issue 6 months ago • 7 comments

PR description:

Resolves https://github.com/cms-sw/cmssw/issues/30487 by removing

PhysicsTools/HepMCCandAlgos/python/genParticleCandidates_cfi.py

and it's derivatives. In the cases where this collection was used, now it's moved to use the genParticles collection

PR validation:

Code compiles, as far as I can tell nothing uses this collection

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is needed

tvami avatar Jun 24 '25 03:06 tvami

cms-bot internal usage

cmsbuild avatar Jun 24 '25 03:06 cmsbuild

@cmsbuild please test

tvami avatar Jun 24 '25 03:06 tvami

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48391/45285

cmsbuild avatar Jun 24 '25 03:06 cmsbuild

A new Pull Request was created by @tvami for master.

It involves the following packages:

  • CommonTools/CandAlgos (reconstruction)
  • GeneratorInterface/AlpgenInterface (generators)
  • PhysicsTools/HepMCCandAlgos (analysis)
  • RecoJets/JetAnalyzers (reconstruction)
  • RecoJets/JetProducers (reconstruction)
  • RecoMET/Configuration (reconstruction)
  • RecoMuon/MuonIdentification (reconstruction)

@bbilin, @jfernan2, @lviliani, @mandrenguyen, @menglu21, @mkirsano, @tvami can you please review it and eventually sign? Thanks. @CeliaFernandez, @Fedespring, @HuguesBrun, @abbiendi, @ahinzmann, @alberto-sanchez, @andrea21z, @bellan, @cericeci, @clelange, @gkasieczka, @gouskos, @jdamgov, @jdolen, @jhgoh, @mariadalfonso, @missirol, @mkirsano, @mmarionncern, @nhanvtran, @rappoccio, @rociovilar, @schoef, @seemasharmafnal, @trocino, @yslai this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 24 '25 03:06 cmsbuild

+1

Size: This PR adds an extra 48KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49a6e6/46882/summary.html COMMIT: a04220a64c74261022151de4607b5c07fd544a40 CMSSW: CMSSW_15_1_X_2025-06-23-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48391/46882/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4058157
  • DQMHistoTests: Total failures: 40
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4058097
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 24 '25 07:06 cmsbuild

+1

jfernan2 avatar Jun 24 '25 13:06 jfernan2

+analysis

  • the diffs in the tests are unrelated

tvami avatar Jun 24 '25 15:06 tvami

@cms-sw/generators-l2 any comments?

tvami avatar Jun 30 '25 15:06 tvami

+1

lviliani avatar Jul 03 '25 08:07 lviliani

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 03 '25 08:07 cmsbuild

+1

mandrenguyen avatar Jul 03 '25 08:07 mandrenguyen