cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[15.0.X] Update HLT MultiTrackValidator

Open mmasciov opened this issue 6 months ago • 10 comments

PR description:

backport of https://github.com/cms-sw/cmssw/pull/48361

As discussed in TSG and Tracking POG meetings, as of today the HLT MTV (multi-track validation) applies different selection wrt. offline. This has historical (?) motivations, not necessarily meaningful. Hence, this PR is:

  • using selections in line with offline (min pT is kept at 0.4 GeV);
  • introducing the possibility to monitor all HLT track collections before quality selections are applied, by storing the relevant collections in appropriate data tiers.

Related to https://its.cern.ch/jira/browse/CMSHLT-3574

PR validation:

E.g., http://uaf-10.t2.ucsd.edu/~mmasciov/TRKPOG/HLT2025/mkFitDoubletRecovery/HLT_2025_TTbarPU_mkFitDR_updatedMTV/plots_hlt.html

Observed differences in the HLT MTV are expected and due to different selections.

FYI @cms-sw/tracking-pog-l2, @mmusich

mmasciov avatar Jun 18 '25 14:06 mmasciov

A new Pull Request was created by @mmasciov for CMSSW_15_0_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTrigger/Configuration (hlt)
  • Validation/RecoTrack (dqm)

@Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please review it and eventually sign? Thanks. @Fedespring, @GiacomoSguazzoni, @HuguesBrun, @Martin-Grunewald, @VinInn, @VourMa, @cericeci, @dgulhan, @felicepantaleo, @jhgoh, @missirol, @mmusich, @mtosi, @rociovilar, @rovere, @trocino, @wmtford this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 18 '25 14:06 cmsbuild

cms-bot internal usage

cmsbuild avatar Jun 18 '25 14:06 cmsbuild

-hlt

  • same comments as in master

mmusich avatar Jun 18 '25 14:06 mmusich

Pull request #48362 was updated. @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @ctarricone, @mmusich, @rseidita can you please check and sign again.

cmsbuild avatar Jun 18 '25 14:06 cmsbuild

Pull request #48362 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.

cmsbuild avatar Jun 18 '25 14:06 cmsbuild

please test

antoniovagnerini avatar Jun 19 '25 12:06 antoniovagnerini

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e704f/46838/summary.html COMMIT: 16af0c3ca1a4bb591f6a835c8b694d11cffc9c9b CMSSW: CMSSW_15_0_X_2025-06-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48362/46838/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 160 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4121776
  • DQMHistoTests: Total failures: 7586
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4114170
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8031.802 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.104,... ): 896.790 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 16834.0,... ): 877.136 KiB HLT/Tracking
  • Checked 222 log files, 194 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 19 '25 15:06 cmsbuild

Pull request #48362 was updated. @antoniovagnerini, @cmsbuild, @ctarricone, @rseidita can you please check and sign again.

cmsbuild avatar Jun 23 '25 17:06 cmsbuild

please test

mmasciov avatar Jun 24 '25 14:06 mmasciov

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e704f/46900/summary.html COMMIT: 2985b9109f1a6ba574a895a33e174cb6b6bee173 CMSSW: CMSSW_15_0_X_2025-06-24-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48362/46900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 20 lines to the logs
  • Reco comparison results: 160 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4120959
  • DQMHistoTests: Total failures: 4543
  • DQMHistoTests: Total nulls: 18
  • DQMHistoTests: Total successes: 4116378
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8685.908 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 145.104,... ): -4.324 KiB HLT/Tracking
  • DQMHistoSizes: changed ( 16834.0,... ): 4358.088 KiB HLT/Tracking
  • Checked 222 log files, 194 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 24 '25 17:06 cmsbuild

+dqm

antoniovagnerini avatar Jun 30 '25 15:06 antoniovagnerini

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jun 30 '25 15:06 cmsbuild

+1

mandrenguyen avatar Jul 07 '25 15:07 mandrenguyen