cmssw Add directories for TICL-EGM code development

PR description:

The purpose of this PR is to:

replace DataFormats/HGCalReco with DataFormats/TICLReco, since at this point the former is a misnomer because it hosts both barrel and endcap reconstruction code;
add a few necessary directories to better organize the development of the Phase 2 TICL reconstruction, in particular in the context of electrons and photons. An example of how this new space will be useful is by hosting a series of new EGamma producers and algorithms that will take as input phase two objects, such as tracksters rather than calo clusters. We believe that duplicating and modifying the current chain of modules, rather than adding options and templating the current modules, is going to be easier and cleaner. The new directories are for the moment empty, because a consistent work of creating such new modules has not been carried out yet. On the other hand, we could rapidly start to fill them up once this PR is merged, as there are other open PRs that contain parts of code which could be nicely accommodated there.

PR validation:

This compiles and passes validation workflows with no differences at reconstruction level.

@valsdav @felicepantaleo @AuroraPerego

Jun 13 '25 15:06 RSalvatico

cms-bot internal usage

Jun 13 '25 15:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48319/45193

Found files with invalid states:
- RecoEgamma/EgammaElectronProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: 177b3966df03ba282907c5eeadf3365d2b69bec1
  - Deleted: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
- RecoTICL/EgammaElectronProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
  - Deleted: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
- RecoTICL/EgammaElectronAlgos/src/ElectronSeedGenerator.cc:
  - Added: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
  - Deleted: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
- RecoTICL/EgammaAlgos/src/ElectronSeedGenerator.cc:
  - Added: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
  - Deleted: 14dd208d2b50ce0b630f9bbad813f674c350ecf3
- RecoTICL/EgammaProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
  - Deleted: 14dd208d2b50ce0b630f9bbad813f674c350ecf3
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/Common.h modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/TICLLayerTile.h modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): #48184
- File RecoHGCal/TICL/plugins/PatternRecognitionbyRecovery.cc modified in PR(s): #48184
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #48221
- File RecoHGCal/TICL/plugins/TICLLayerTileProducer.cc modified in PR(s): #47859
- File RecoParticleFlow/PFClusterProducer/plugins/PFClusterFromHGCalTrackster.cc modified in PR(s): #47859

Jun 13 '25 16:06 cmsbuild

please test

Jun 13 '25 19:06 RSalvatico

-1

Failed Tests: Build ClangBuild Size: This PR adds an extra 480KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa6423/46715/summary.html COMMIT: 0463914f84f8c1cadf1e3b449f66e7984a9e9ec3 CMSSW: CMSSW_15_1_X_2025-06-13-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48319/46715/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

config/SCRAM/GMake/Makefile.rules:1920: warning: overriding recipe for target 'all_RecoEgammaEgammaElectronProducers'
config/SCRAM/GMake/Makefile.rules:1913: warning: ignoring old recipe for target 'all_RecoEgammaEgammaElectronProducers'
>> Local Products Rules ..... done
****WARNING: Invalid tool /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk_USE_ERR+=SimTracker/TrackerMaterialAnalysis. Please fix /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk file.
****WARNING: Invalid tool SimG4Core/PrintGeomInfo. Please fix /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk file.
gmake: Circular /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk > Subsystem BigProducts built
>> Building CMSSW version CMSSW_15_1_X_2025-06-13-1100 ----
>> Creating project symlinks
touch: cannot touch '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk': Read-only file system

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' /usr/bin/time -v scram build -k -j 32 COMPILER='llvm compile'

config/SCRAM/GMake/Makefile.rules:1920: warning: overriding recipe for target 'all_RecoEgammaEgammaElectronProducers'
config/SCRAM/GMake/Makefile.rules:1913: warning: ignoring old recipe for target 'all_RecoEgammaEgammaElectronProducers'
>> Local Products Rules ..... done
****WARNING: Invalid tool /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk_USE_ERR+=SimTracker/TrackerMaterialAnalysis. Please fix /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk file.
****WARNING: Invalid tool SimG4Core/PrintGeomInfo. Please fix /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk file.
gmake: Circular /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02893/el8_amd64_gcc12/cms/cmssw/CMSSW_15_1_X_2025-06-13-1100/.SCRAM/el8_amd64_gcc12/MakeData/DirCache.mk > Creating project symlinks
>> Entering Package DataFormats/HGCalReco
>> Entering Package DataFormats/TICLReco
>> Entering Package Fireworks/Calo

Jun 13 '25 19:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48319/45257

Found files with invalid states:
- RecoEgamma/EgammaElectronProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: 177b3966df03ba282907c5eeadf3365d2b69bec1
  - Deleted: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
- RecoTICL/EgammaElectronProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
  - Deleted: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
- RecoTICL/EgammaElectronAlgos/src/ElectronSeedGenerator.cc:
  - Added: d7c39dbe5fe9a561ba50e66613c5b485840e96c4
  - Deleted: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
- RecoTICL/EgammaAlgos/src/ElectronSeedGenerator.cc:
  - Added: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
  - Deleted: 14dd208d2b50ce0b630f9bbad813f674c350ecf3
- RecoTICL/EgammaProducers/plugins/ElectronSeedProducerFromTracksters.cc:
  - Added: f361dc85a2096d8c94ecb058ff5e374fadb6dd9f
  - Deleted: 14dd208d2b50ce0b630f9bbad813f674c350ecf3
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/src/classes_def.xml modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/Common.h modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/TICLLayerTile.h modified in PR(s): #47859
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): #48184
- File RecoHGCal/TICL/plugins/PatternRecognitionbyRecovery.cc modified in PR(s): #48184
- File RecoHGCal/TICL/plugins/SimTrackstersProducer.cc modified in PR(s): #48221
- File RecoHGCal/TICL/plugins/TICLLayerTileProducer.cc modified in PR(s): #47859
- File RecoParticleFlow/PFClusterProducer/plugins/PFClusterFromHGCalTrackster.cc modified in PR(s): #47859

Jun 19 '25 14:06 cmsbuild

Pull request #48319 was updated.

Jun 19 '25 14:06 cmsbuild

please test

Jun 19 '25 14:06 RSalvatico

-1

Failed Tests: RelVals-INPUT Size: This PR adds an extra 20KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa6423/46840/summary.html COMMIT: 11f38bae61d451390cfa974e6479b0426405dca0 CMSSW: CMSSW_15_1_X_2025-06-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48319/46840/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

140.042140.042_RunSingleMuon2022C/step2_RunSingleMuon2022C.log

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4050825
DQMHistoTests: Total failures: 95
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4050710
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

Jun 19 '25 17:06 cmsbuild

please test

Jun 24 '25 12:06 RSalvatico

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa6423/46894/summary.html COMMIT: 11f38bae61d451390cfa974e6479b0426405dca0 CMSSW: CMSSW_15_1_X_2025-06-23-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48319/46894/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4058157
DQMHistoTests: Total failures: 40
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4058097
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

Jun 24 '25 15:06 cmsbuild

Not sure why this PR didn't trigger the usual "A new pull request was created by [...]" message, tagging the list of signatories. @cms-sw/orp-l2

Jul 04 '25 16:07 RSalvatico

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

DataFormats/HGCalReco (reconstruction, upgrade)
DataFormats/TICLEgammaReco (****)
DataFormats/TICLReco (****)
Fireworks/Calo (visualization)
RecoEgamma/EgammaElectronAlgos (reconstruction)
RecoHGCal/TICL (reconstruction, upgrade)
RecoParticleFlow/PFClusterProducer (reconstruction)
RecoParticleFlow/PFProducer (reconstruction)
RecoTICL/EgammaAlgos (****)
RecoTICL/EgammaProducers (****)
RecoTICL/README.md (****)
SimCalorimetry/HGCalAssociatorProducers (simulation, upgrade)
SimDataFormats/Associations (simulation)
SimDataFormats/CaloAnalysis (simulation)
Validation/HGCalValidation (dqm)

The following packages do not have a category, yet:

DataFormats/TICLEgammaReco DataFormats/TICLReco RecoTICL/EgammaAlgos RecoTICL/EgammaProducers RecoTICL/README.md Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@Dr15Jones, @Moanwar, @alja, @antoniovagnerini, @civanch, @ctarricone, @jfernan2, @kpedro88, @makortel, @mandrenguyen, @mdhildreth, @rseidita, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Prasant1993, @ReyerBand, @Sam-Harper, @a-kapoor, @afiqaize, @alja, @apsallid, @bsunanda, @cseez, @denizsun, @fabiocos, @felicepantaleo, @forthommel, @hatakeyamak, @jainshilpi, @lecriste, @lgray, @martinamalberti, @missirol, @mmarionncern, @mmusich, @pfs, @ram1123, @rovere, @salimcerci, @sameasy, @seemasharmafnal, @sethzenz, @sobhatta, @thomreis, @valsdav, @vandreev11, @varuns23, @wang0jin, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Jul 04 '25 16:07 cmsbuild

Not sure why this PR didn't trigger the usual "A new pull request was created by [...]" message, tagging the list of signatories.

Well, it just did.

Jul 04 '25 16:07 RSalvatico

It involves the following packages: ...

RecoTICL/README.md (****)

A lot of our machinery will treat the RecoTICL/README.md as a package instead of a file.

@smuzaffar

Jul 07 '25 13:07 makortel

It involves the following packages: ...

RecoTICL/README.md (****)

A lot of our machinery will treat the RecoTICL/README.md as a package instead of a file.

@smuzaffar

For me it doesn't necessarily need to exist, but we thought it made some sense to have one there for the time being. If it's troublesome, it can go away.

Jul 07 '25 20:07 RSalvatico

@RSalvatico , yes tools like git-cms-[add|rm]pkg will break due to CMSSW Subsystem level files. If you want to keep subsystem level documentation then better to create RecoTICL/Documentation and move README.md under that

Jul 08 '25 05:07 smuzaffar

+1

Jul 08 '25 16:07 alja

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48319/45473

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48319/45473/cms-checkout-topic.log

Jul 10 '25 12:07 cmsbuild

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

Sep 10 '25 06:09 cmsbuild