cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

Warnings about `UnusedProductsForCanDeleteEarly` in the phase-2 HLT menu

Open mmusich opened this issue 6 months ago • 3 comments

Many phase-2 workflow execute some variant of the phase-2 HLT menu and invariably there are warnings of the type:

%MSG-w UnusedProductsForCanDeleteEarly:  AfterModDestruction  11-Jun-2025 03:51:06 CEST pre-events
The following products in the 'canDeleteEarly' list are not used in this job and will be ignored.
 If possible, remove the producer from the job.
 IntermediateHitDoublets_hltElePixelHitDoubletsL1Seeded__HLT
 IntermediateHitDoublets_hltElePixelHitDoubletsUnseeded__HLT
 RegionsSeedingHitSets_hltElePixelHitDoubletsForTripletsL1Seeded__HLT
 RegionsSeedingHitSets_hltElePixelHitDoubletsForTripletsUnseeded__HLT
%MSG

found in them. See e.g: here.

These seem arise from

https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/RecoTracker/Configuration/python/customiseEarlyDeleteForSeeding.py#L12-L18

On the other hand it's not clear what's the action item, as just removing the producers will not work as the products are actually consumed, e.g.:

https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelSeedsDoubletsL1Seeded_cfi.py#L14

https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelSeedsDoubletsUnseeded_cfi.py#L14

https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelHitTripletsL1Seeded_cfi.py#L10

https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelHitTripletsUnseeded_cfi.py#L10

mmusich avatar Jun 11 '25 09:06 mmusich

cms-bot internal usage

cmsbuild avatar Jun 11 '25 09:06 cmsbuild

A new Issue was created by @mmusich.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

cmsbuild avatar Jun 11 '25 09:06 cmsbuild

I am not sure to whom does this issue needs to be assigned. Can someone of the managers please follow-up?

mmusich avatar Jun 18 '25 07:06 mmusich

AFAICT hltElePixelHitDoubletsL1Seeded is defined in https://github.com/cms-sw/cmssw/blob/515dff431bdfe4efa6bb6c9b46bb27041e5ab84f/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelHitDoubletsL1Seeded_cfi.py#L3-L12

Both produceIntermediateHitDoublets and produceSeedingHitSets are set to True.

On the consumer side https://github.com/cms-sw/cmssw/blob/0455dbf9d25a0d3b2acdfb4c7a085db1f41e46a9/HLTrigger/Configuration/python/HLT_75e33/modules/hltElePixelSeedsDoubletsL1Seeded_cfi.py#L14 corresponds to https://github.com/cms-sw/cmssw/blob/515dff431bdfe4efa6bb6c9b46bb27041e5ab84f/RecoTracker/TkSeedGenerator/interface/SeedCreatorFromRegionHitsEDProducerT.h#L39 i.e. the consumer consumes the RegionsSeedingHitSets. The framework printout indicates that the IntermediateHitDoublets data product is not used for anything in the job.

Assuming the other 3 cases would be similar, I'd expect the printout to disappear with

process.hltElePixelHitDoubletsL1Seeded.produceIntermediateHitDoublets = False
process.hltElePixelHitDoubletsUnseeded.produceIntermediateHitDoublets = False
process.hltElePixelHitDoubletsForTripletsL1Seeded.produceSeedingHitSets = False
process.hltElePixelHitDoubletsForTripletsUnseeded.produceSeedingHitSets = False

makortel avatar Jul 02 '25 22:07 makortel

assign hlt, upgrade

makortel avatar Jul 02 '25 22:07 makortel

New categories assigned: hlt,upgrade

@Martin-Grunewald,@mmusich,@Moanwar,@srimanob,@subirsarkar you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild avatar Jul 02 '25 22:07 cmsbuild

Assuming the other 3 cases would be similar, I'd expect the printout to disappear with

Thanks! I have followed up at https://github.com/cms-sw/cmssw/pull/48470

mmusich avatar Jul 03 '25 07:07 mmusich

+hlt

  • fixed by https://github.com/cms-sw/cmssw/pull/48470

mmusich avatar Jul 04 '25 07:07 mmusich

I am going to close this issue. @cms-sw/upgrade-l2 feel free to sign.

mmusich avatar Jul 10 '25 12:07 mmusich

+Upgrade

Moanwar avatar Jul 10 '25 13:07 Moanwar

This issue is fully signed and ready to be closed.

cmsbuild avatar Jul 10 '25 13:07 cmsbuild