cmssw [L1T] L1 Scouting multi-BX Online Selection based on BMTF stubs

PR description:

This PR introduces an additional online selector module for L1 Scouting to target Heavy Stable Charged Particles signatures leaving BMTF stubs in multiple consecutive bunch crossings (e.g. link). The special thing of this module with respect to the others, existing in L1TriggerScouting/OnlineProcessing, is that its processing logic targets a BX window rather than single BXs. The original work has been done by @EltonSh and cleaned for this PR.

PR validation:

The PR has been validate using files collected in the "Zero Bias" stream, e.g.

cmsRun L1TriggerScouting/OnlineProcessing/test/L1ScoutingSelector.py inFile=root://cms-xrd-global.cern.ch//store/data/Run2024G/L1Scouting/L1SCOUT/v1/000/383/996/00001/4c1c76a1-bf29-4bfb-ae13-1e51a064fd69.root outFile=file:selection_4c1c76a1-bf29-4bfb-ae13-1e51a064fd69.root numOrbits=100

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

We would like this PR to be backported in a data-taking release (15_0_X) in order to collect data from pp collisions during 2025.

Jun 10 '25 18:06 RoccoA97

cms-bot internal usage

Jun 10 '25 18:06 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45136

ERROR: Build errors found during clang-tidy run.

src/L1TriggerScouting/OnlineProcessing/plugins/BMTFStubMultiBxSelector.cc:13:10: error: 'FWCore/Utilities/interface/Span.h' file not found [clang-diagnostic-error]
   13 | #include "FWCore/Utilities/interface/Span.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppressed 802 warnings (802 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Jun 10 '25 18:06 cmsbuild

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45137

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45137/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45137/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

Jun 10 '25 18:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45183

Jun 13 '25 10:06 cmsbuild

Pull request #48289 was updated.

Jun 13 '25 10:06 cmsbuild

please test

Jun 16 '25 14:06 BenjaminRS

A new Pull Request was created by @RoccoA97 for master.

It involves the following packages:

L1TriggerScouting/OnlineProcessing (l1, daq)

@BenjaminRS, @emeschi, @quinnanm, @smorovic can you please review it and eventually sign? Thanks. @Martin-Grunewald, @Mmiglio, @missirol, @mmusich this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Jun 16 '25 14:06 cmsbuild

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f61996/46772/summary.html COMMIT: b1adddaf2502b4464b48ed648207b8bb789d0e5d CMSSW: CMSSW_15_1_X_2025-06-16-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48289/46772/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 3 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4050825
DQMHistoTests: Total failures: 20
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4050785
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

Jun 16 '25 17:06 cmsbuild

+daq

Jun 16 '25 17:06 smorovic

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45298

Jun 25 '25 08:06 cmsbuild

Pull request #48289 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

Jun 25 '25 08:06 cmsbuild

+1

Jun 25 '25 20:06 smorovic

please test

Jun 30 '25 20:06 quinnanm

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f61996/47018/summary.html COMMIT: a29f4b89b7caac858b2b01ccc66011780f8ed761 CMSSW: CMSSW_15_1_X_2025-06-30-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48289/47018/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4065749
DQMHistoTests: Total failures: 7374
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4058355
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 48 workflows

Jun 30 '25 23:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48289/45435

Jul 08 '25 08:07 cmsbuild

Pull request #48289 was updated. @BenjaminRS, @cmsbuild, @emeschi, @quinnanm, @smorovic can you please check and sign again.

Jul 08 '25 08:07 cmsbuild

please test

Jul 08 '25 12:07 BenjaminRS

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f61996/47130/summary.html COMMIT: 27c378d26a67e4b17d54930edc213a2cdec14480 CMSSW: CMSSW_15_1_X_2025-07-08-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48289/47130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4067201
DQMHistoTests: Total failures: 25
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4067156
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 215 log files, 184 edm output root files, 50 DQM output files
TriggerResults: no differences found

Jul 08 '25 14:07 cmsbuild

+l1

Jul 08 '25 14:07 quinnanm

+daq

Jul 08 '25 14:07 smorovic

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

Jul 08 '25 14:07 cmsbuild

+1

Jul 09 '25 20:07 mandrenguyen