cms-sw
Reduce LogError noise when using (E)EoR3 CPE conditions
PR description:
This PR addressed the issue reported in https://github.com/cms-sw/cmssw/issues/47857
PR validation:
The code compiles and has been tested with a private cmsRun job that was producing a storm of LogErrors. No change in physics performance expected.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport to CMSSW_15_0_X
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48263/45086
A new Pull Request was created by @ferencek for master.
It involves the following packages:
- CondFormats/SiPixelTransient (db, reconstruction)
- RecoLocalTracker/SiPixelRecHits (reconstruction)
@atpathak, @cmsbuild, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks. @GiacomoSguazzoni, @JanChyczynski, @PonIlya, @VinInn, @VourMa, @dkotlins, @felicepantaleo, @ferencek, @gpetruc, @missirol, @mmusich, @mroguljic, @mtosi, @rovere, @rsreds, @seemasharmafnal, @threus, @tsusa, @tvami, @yuanchao this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
I am confused by the scope of this PR. IIUC this is demoting errors to debug level messages. But the underlying source of the errors is not addressed. Is that understood?
I am confused by the scope of this PR. IIUC this is demoting errors to debug level messages. But the underlying source of the errors is not addressed. Is that understood?
Hi @mmusich, here is a reply from Morris that I am relaying:
The pull request includes a fix to suppress an irrelevant error message. The pixel template reconstruction works by first identifying which of 40 positions of a precomputed cluster shape best describes the observed cluster shape. At each of the positions, a chisquare estimator is computed by varying an overall scale factor so that only the shapes are compared. Sometimes when the cluster and templated shape are sufficiently misaligned, the minimization would produce a zero factor in the denominator of part of the scale factor solution. When this happens, a default value is used and it triggers an error message. The default value produces a chisquare which is larger than the minimum and does not affect functioning of the algorithm. The error message has become more common with the very radiation damaged first layer. To avoid unnecessarily alarming colleagues, the message has been suppressed.
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713ca5/47127/summary.html
COMMIT: d04ff8779cc8e8521f117e16a93d296a6afb9dd9
CMSSW: CMSSW_15_1_X_2025-07-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48263/47127/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 2153 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4067201
- DQMHistoTests: Total failures: 17314
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4049867
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
DQMHistoTests: Total failures: 17314
this looks very similar in pattern to the reproducibility issues reported at https://github.com/cms-sw/cmssw/pull/48146#issuecomment-3045084566
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713ca5/47409/summary.html
COMMIT: d04ff8779cc8e8521f117e16a93d296a6afb9dd9
CMSSW: CMSSW_15_1_X_2025-07-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48263/47409/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 2162 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4076162
- DQMHistoTests: Total failures: 17357
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4058785
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.