cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[10_6_X] Add switch for scalar sum to LHEPtFilter

Open jsamudio opened this issue 6 months ago • 6 comments

PR description:

Backport of #48250. The only difference is that the filter resides in the GeneratorInterface/GenFilters/src directory to preserve the structure in this release.

PR validation:

Validated through adding the filter to a MCM test script and checking the results are as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #48250, and it is needed for generation Run 2 UL samples.

@hatakeyamak

jsamudio avatar Jun 04 '25 22:06 jsamudio

A new Pull Request was created by @jsamudio for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jun 04 '25 22:06 cmsbuild

cms-bot internal usage

cmsbuild avatar Jun 04 '25 22:06 cmsbuild

We need this filter update to produce some Run 2 UL MC request. Can we request the review? Who will be the reviewer?

hatakeyamak avatar Jun 18 '25 12:06 hatakeyamak

We need this filter update to produce some Run 2 UL MC request. Can we request the review? Who will be the reviewer?

I guess we have to ask somebody from generators group to review, but I am not sure exactly who.

hatakeyamak avatar Jun 18 '25 12:06 hatakeyamak

please test

lviliani avatar Jun 23 '25 16:06 lviliani

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10325/46880/summary.html COMMIT: cf6cc5f97899d3edae731b1348e8f95c220634b8 CMSSW: CMSSW_10_6_X_2025-06-22-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48251/46880/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 23 '25 18:06 cmsbuild

+1

lviliani avatar Jul 03 '25 08:07 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 03 '25 08:07 cmsbuild

Pull request #48251 was updated. @bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please check and sign again.

cmsbuild avatar Jul 08 '25 20:07 cmsbuild

please test

lviliani avatar Jul 14 '25 09:07 lviliani

+1

Size: This PR adds an extra 12KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c10325/47214/summary.html COMMIT: 47f2588ab2a4c82b29436693a53e2e512cd458e1 CMSSW: CMSSW_10_6_X_2025-07-13-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48251/47214/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 14 '25 11:07 cmsbuild

+1

lviliani avatar Jul 22 '25 07:07 lviliani

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Jul 22 '25 07:07 cmsbuild

Please backport to all active intermediate release cycles: 11_2, 12_4, 13_, 14_, 15_*

mandrenguyen avatar Jul 22 '25 07:07 mandrenguyen

+1

mandrenguyen avatar Jul 22 '25 21:07 mandrenguyen