cms-sw
Add switch for scalar sum to LHEPtFilter
PR description:
This PR is intended to add additional functionality to the existing LHEPtFilter. A boolean configuration option is added to specify if the pT sum should be a scalar or vector sum. The default behavior is preserved via fillDescriptions. The purpose for this addition is primarily motivated by a need to filter POWHEG ttbb 4f samples during generation in a way that works uniformly across every decay channel.
PR validation:
This PR was validated by adding the filter during a GEN step when reading from an LHE, and worked as expected. Since the original functionality should be preserved as default, I do not expect any issues to arise for workflows which may already make use of this filter.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR should be backported to CMSSW_10_6_X for use in generating Run 2 UL samples.
@hatakeyamak
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48250/45058
A new Pull Request was created by @jsamudio for master.
It involves the following packages:
- GeneratorInterface/GenFilters (generators)
@bbilin, @cmsbuild, @lviliani, @menglu21, @mkirsano can you please review it and eventually sign? Thanks. @alberto-sanchez, @mkirsano this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
We need this filter update to produce some Run 2 UL MC request. Can we request the review? Who will be the reviewer?
We need this filter update to produce some Run 2 UL MC request. Can we request the review? Who will be the reviewer?
And, also Run 3 MC requests.
It would be nice to show the validation of this new feature in one of the upcoming GEN meetings, given that this has never been discussed to my knowledge (but please correct me if I'm wrong).
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43b8df/46816/summary.html
COMMIT: d20259f42f4a3c768e5a5cb0b5dd94db6f5370ff
CMSSW: CMSSW_15_1_X_2025-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48250/46816/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 2 lines to the logs
- Reco comparison results: 6 differences found in the comparisons
- DQMHistoTests: Total files compared: 50
- DQMHistoTests: Total histograms compared: 4050825
- DQMHistoTests: Total failures: 30
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4050775
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
- Checked 215 log files, 184 edm output root files, 50 DQM output files
- TriggerResults: no differences found
It would be nice to show the validation of this new feature in one of the upcoming GEN meetings, given that this has never been discussed to my knowledge (but please correct me if I'm wrong).
Who should I reach out to regarding scheduling a slot in a GEN meeting?
@lviliani thank you. can you let @jsamudio know how he can get a slot in a GEN meeting?
Hi @hatakeyamak @jsamudio, we have a slot available for a quick report during the GEN meeting next Monday June 30 at 2 pm (CERN time). If it's ok for you, I will add you to the agenda. If not, we can follow-up offline to avoid unnecessary delays.
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
