cms-sw
TICL trackster raw pT from position
Introduced Trackster::calculateRawPt() and Trackster::calculateRawEmPt() methods.
These methods compute raw_pt = raw_energy / cosh(eta) and raw_em_pt = raw_em_energy / cosh(eta), using the barycenter_.eta() to avoid instability problems found with pT calculated from the PCA.
Updated PatternRecognitionbyRecovery to use the new methods instead of duplicating the logic.
Initialized relevant member variables to avoid potential undefined behavior.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48184/44959
A new Pull Request was created by @felicepantaleo for master.
It involves the following packages:
- DataFormats/HGCalReco (upgrade, reconstruction)
- RecoHGCal/TICL (upgrade, reconstruction)
@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @apsallid, @denizsun, @forthommel, @hatakeyamak, @lecriste, @missirol, @mmusich, @rovere, @salimcerci, @sameasy, @sobhatta, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
test parameters:
- workflow_opts= -w upgrade
- workflow = 29896.203, 29691.203, 29691.204
- enable = hlt_p2_integration, hlt_p2_timing
+1
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8079e/46389/summary.html
COMMIT: 03c95d9e8b7a6b0811c37cc082741527d06308be
CMSSW: CMSSW_15_1_X_2025-05-27-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48184/46389/install.sh to create a dev area with all the needed externals and cmssw changes.
-
DAS Queries: The DAS query tests failed, see the summary page for details.
-
HLT P2 Timing: chart
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 409 differences found in the comparisons
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4429609
- DQMHistoTests: Total failures: 1336
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4428253
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 229 log files, 196 edm output root files, 53 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
there are some differences in the comparisons that I need to review before merging this. Don't merge it yet please.
Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48184/45885
- There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): #48319
- File RecoHGCal/TICL/plugins/PatternRecognitionbyRecovery.cc modified in PR(s): #48319
Pull request #48184 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48184/45889
- There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/HGCalReco/interface/Trackster.h modified in PR(s): #48319
- File RecoHGCal/TICL/plugins/PatternRecognitionbyRecovery.cc modified in PR(s): #48319
- File RecoHGCal/TICL/plugins/TracksterLinkingbySkeletons.cc modified in PR(s): #48319
Pull request #48184 was updated. @Moanwar, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please check and sign again.
+1
Size: This PR adds an extra 44KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8079e/47844/summary.html
COMMIT: a5135db1eba1d75ad51725a40bcaa75f558769f7
CMSSW: CMSSW_15_1_X_2025-08-25-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48184/47844/install.sh to create a dev area with all the needed externals and cmssw changes.
-
DAS Queries: The DAS query tests failed, see the summary page for details.
-
HLT P2 Timing: chart
Comparison Summary
Summary:
- You potentially removed 1 lines from the logs
- Reco comparison results: 0 differences found in the comparisons
- DQMHistoTests: Total files compared: 53
- DQMHistoTests: Total histograms compared: 4522271
- DQMHistoTests: Total failures: 2358
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 4519893
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
- Checked 229 log files, 196 edm output root files, 53 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
