cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

Introduce L1ScoutingNanoAOD for Run3

Open patinkaew opened this issue 7 months ago • 10 comments

PR description:

Please also note contributions from @gpetruc, @Mmiglio for initial and important components of L1ScoutingNano as well as L1Scouting team for numerous valuable feedbacks.

This PR introduces L1ScoutingNanoAOD workflow for Run3. For L1Scouting data, each processing event is actually an orbit (in OrbitCollection), different OutputModule is needed to convert orbits to bunch crossings (bx).

Some key features:

  • OrbitNanoAODOutputModule is analogous to NanoAODOutputModule and is used to convert orbits to bxs.
  • OrbitFlatTable is analogous to nanoaod::FlatTable and contains offsets of each bx in an orbit
  • SimpleOrbitFlatTableProducer is analogous to SimpleFlatTableProducer and has all functionalities of SimpleFlatTableProducer.

Two custom NanoAOD flavours are added: @L1Scout for ZeroBias stream and @L1ScoutSelect for Selection stream.

Event content files (html) can be found here on CERNBOX.

PR validation:

Pass all tests from scram b runtests use-ibeos.

Two relval_nano workflows are added for each flavour. Pass these two workflows from runTheMatrix.py -l 2500.240,2500.241

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is not a backport.

patinkaew avatar May 23 '25 21:05 patinkaew

cms-bot internal usage

cmsbuild avatar May 23 '25 21:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/44934

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #48104, #48152
    • File DataFormats/L1Scouting/interface/OrbitCollection.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes_def.xml modified in PR(s): #48093
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #48091

cmsbuild avatar May 23 '25 21:05 cmsbuild

enable nano

ftorrresd avatar Jun 17 '25 13:06 ftorrresd

please test

ftorrresd avatar Jun 17 '25 13:06 ftorrresd

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/46799/summary.html COMMIT: fe95b32fdd400861f624332628f9f46afe941d04 CMSSW: CMSSW_15_1_X_2025-06-16-2300/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48163/46799/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it? You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/46799/git-merge-result

cmsbuild avatar Jun 17 '25 13:06 cmsbuild

Hi @ftorrresd,

Sorry for a delay. I just fix the merge conflict.

Please note that the workflow numbers for L1ScoutingNano have changed (since BPHNano workflow in 140X was removed in master).

2500.239 L1Scouting2024RAW14.0+l1ScoutingNANO_data14.0 
2500.24 L1ScoutingSelection2024RAW14.0+l1ScoutingSelectionNANO_data14.0

Best, Patin

patinkaew avatar Jun 23 '25 10:06 patinkaew

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/45278

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DataFormats/L1Scouting/interface/OrbitCollection.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes_def.xml modified in PR(s): #48093

cmsbuild avatar Jun 23 '25 10:06 cmsbuild

Pull request #48163 was updated.

cmsbuild avatar Jun 23 '25 10:06 cmsbuild

please test

ftorrresd avatar Jun 23 '25 11:06 ftorrresd

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/46872/summary.html COMMIT: 4fdcdbc3fd6451f67ef942f4c73b851d73ab3224 CMSSW: CMSSW_15_1_X_2025-06-23-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48163/46872/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

The workflows 2500.271, 2500.261 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • You potentially added 790 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 74620
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 74620
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 19 files compared)
  • Checked 116 log files, 70 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.239_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.239_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.24_L1ScoutingSelectionNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.24_L1ScoutingSelectionNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.251_l1DPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.251_l1DPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.252_muDPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.252_muDPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.253_muDPGNANOBkg140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.253_muDPGNANOBkg140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.254_hcalDPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.254_hcalDPGNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.255_hcalDPGCalibNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.255_hcalDPGCalibNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.261_hcalDPGMCNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.261_hcalDPGMCNANO140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.271_NANOmc2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.271_NANOmc2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.281_NANOdata2024reMINI-size.json
  • Nano ERROR: Missing ref/2500.281_NANOdata2024reMINI-size.json
workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.001 3.118 3.118 0.000 ( +0.0% ) 3.76 3.73 +1.0% 2.637 2.802
NANOmc106Xul17v2 2500.002 3.177 3.177 0.000 ( +0.0% ) 3.52 3.47 +1.4% 2.648 3.288
NANOmc106Xul18v2 2500.003 3.128 3.128 0.000 ( +0.0% ) 3.58 3.54 +1.0% 2.665 3.269
NANOdata106Xul16v2 2500.011 1.560 1.560 0.000 ( +0.0% ) 6.14 6.14 -0.0% 2.341 2.845
NANOdata106Xul17v2 2500.012 1.948 1.948 0.000 ( +0.0% ) 4.13 4.16 -0.5% 2.397 3.025
NANOdata106Xul18v2 2500.013 1.914 1.914 0.000 ( +0.0% ) 4.95 4.96 -0.2% 2.434 2.990
NANOmcUL16APVreMINI 2500.021 0.022 0.022 0.000 ( +0.0% ) 1.71 1.72 -0.7% 2.606 2.967
NANOmcUL16reMINI 2500.022 0.022 0.022 0.000 ( +0.0% ) 1.59 1.63 -2.4% 2.599 2.981
NANOmcUL17reMINI 2500.023 0.022 0.022 0.000 ( +0.0% ) 1.53 1.55 -1.7% 2.561 2.690
NANOmcUL18reMINI 2500.024 0.022 0.022 0.000 ( +0.0% ) 1.30 1.31 -0.4% 2.755 3.104
NANOdataUL16APVreMINI 2500.031 0.035 0.035 0.000 ( +0.0% ) 1.33 1.32 +1.0% 2.691 2.919
NANOdataUL16reMINI 2500.032 0.036 0.036 0.000 ( +0.0% ) 1.50 1.51 -0.5% 2.623 2.939
NANOdataUL17reMINI 2500.033 0.037 0.037 0.000 ( +0.0% ) 1.31 1.29 +1.1% 2.718 2.942
NANOdataUL18reMINI 2500.034 0.036 0.036 0.000 ( +0.0% ) 1.30 1.27 +2.5% 2.706 2.928
NANOmc130X 2500.101 3.220 3.220 0.000 ( +0.0% ) 4.33 4.28 +1.2% 2.440 3.232
NANOdata130Xrun3 2500.111 1.799 1.799 0.000 ( +0.0% ) 6.40 6.38 +0.3% 2.651 2.817
ScoutingNANOdata130Xrun3 2500.131 0.771 0.771 0.000 ( +0.0% ) 33.19 33.24 -0.1% 1.540 1.692
muPOGNANOmc140X 2500.221 2.065 2.065 0.000 ( +0.0% ) 5.41 5.48 -1.2% 2.179 2.366
EGMNANOmc140X 2500.222 3.876 3.876 0.000 ( +0.0% ) 3.92 3.96 -1.0% 2.475 2.725
BTVNANOmc140X 2500.223 10.607 10.607 0.000 ( +0.0% ) 2.50 2.50 -0.3% 2.633 2.946
jmeNANOmc140X 2500.224 6.666 6.666 0.000 ( +0.0% ) 1.13 1.14 -1.1% 2.448 2.790
lepTrackInfoNANOmc140X 2500.226 3.570 3.570 0.000 ( +0.0% ) 3.91 3.95 -0.9% 2.446 2.714
ScoutingNANOmc140X 2500.227 1.486 1.486 0.000 ( +0.0% ) 15.41 15.40 +0.1% 1.944 2.034
ScoutingNANOwithPromptmc140X 2500.228 4.474 4.474 0.000 ( +0.0% ) 3.34 3.34 +0.0% 2.696 2.978
muPOGNANO140Xrun3 2500.231 1.469 1.469 0.000 ( +0.0% ) 7.51 7.60 -1.3% 2.418 2.643
EGMNANOdata140Xrun3 2500.232 2.623 2.623 0.000 ( +0.0% ) 5.60 5.67 -1.3% 2.421 3.019
BTVNANOdata140Xrun3 2500.233 5.612 5.612 0.000 ( +0.0% ) 3.49 3.72 -6.3% 2.499 3.231
jmeNANOdata140Xrun3 2500.234 3.976 3.976 0.000 ( +0.0% ) 1.46 1.46 -0.2% 2.379 2.865
lepTrackInfoNANOdata140Xrun3 2500.236 2.413 2.413 0.000 ( +0.0% ) 5.57 5.79 -3.7% 2.352 3.010
ScoutingNANOdata140Xrun3 2500.237 1.101 1.101 0.000 ( +0.0% ) 29.10 29.69 -2.0% 1.306 1.680
ScoutingNANOwithPromptdata140Xrun3 2500.238 2.783 2.783 0.000 ( +0.0% ) 5.05 5.03 +0.5% 3.073 3.248
NANOmc150X 2500.301 3.218 3.218 0.000 ( +0.0% ) 17.80 17.55 +1.4% 2.711 2.774
NANOdata150X 2500.311 2.144 2.144 0.000 ( +0.0% ) 34.45 33.95 +1.5% 2.236 2.496
NANOdata150X 2500.312 2.630 2.630 0.000 ( +0.0% ) 22.77 22.22 +2.5% 2.392 2.585
muPOGNANOmc150X 2500.321 2.255 2.255 0.000 ( +0.0% ) 15.33 14.99 +2.3% 2.440 2.649
EGMNANOmc150X 2500.322 4.110 4.110 0.000 ( +0.0% ) 13.97 13.52 +3.4% 2.531 2.746
BTVNANOmc150X 2500.323 10.551 10.551 0.000 ( +0.0% ) 4.83 4.75 +1.7% 2.892 2.971
jmeNANOmc150X 2500.324 6.760 6.760 0.000 ( +0.0% ) 1.33 1.34 -0.4% 2.677 2.939
jmeNANOrePuppimc150X 2500.325 6.762 6.762 0.000 ( +0.0% ) 1.25 1.25 -0.3% 2.920 3.192
lepTrackInfoNANOmc150X 2500.326 3.720 3.720 0.000 ( +0.0% ) 14.55 14.72 -1.2% 2.619 2.748
ScoutingNANOmc150X 2500.327 1.562 1.562 0.000 ( +0.0% ) 18.93 19.09 -0.8% 2.411 2.553
ScoutingNANOwithPromptmc150X 2500.328 4.773 4.773 0.000 ( +0.0% ) 10.48 10.59 -1.0% 2.780 2.986
BPHNANOmc150X 2500.329 4.127 4.127 0.000 ( +0.0% ) 16.81 16.97 -0.9% 2.737 2.829
muPOGNANO150Xrun3 2500.331 1.125 1.125 0.000 ( +0.0% ) 25.15 24.04 +4.6% 2.373 2.397
EGMNANOdata150Xrun3 2500.332 2.985 2.985 0.000 ( +0.0% ) 22.60 21.42 +5.5% 2.464 2.492
BTVNANOdata150Xrun3 2500.333 7.971 7.971 0.000 ( +0.0% ) 5.69 5.71 -0.2% 2.402 2.713
jmeNANOdata150Xrun3 2500.334 4.349 4.349 0.000 ( +0.0% ) 1.65 1.64 +0.6% 2.448 2.650
jmeNANOrePuppidata150Xrun3 2500.335 4.332 4.332 0.000 ( +0.0% ) 1.42 1.43 -0.7% 2.617 2.916
lepTrackInfoNANOdata150Xrun3 2500.336 2.625 2.625 0.000 ( +0.0% ) 24.11 24.26 -0.6% 2.156 2.481
ScoutingNANOdata150Xrun3 2500.337 1.737 1.737 0.000 ( +0.0% ) 30.85 30.95 -0.3% 1.516 1.702
ScoutingNANOwithPromptdata150Xrun3 2500.338 2.601 2.601 0.000 ( +0.0% ) 17.46 17.39 +0.4% 2.582 2.811
BPHNANOdata150Xrun3 2500.339 2.632 2.632 0.000 ( +0.0% ) 33.36 33.27 +0.3% 2.391 2.554
TTbarMINIAOD10.6_UL18v2 2500.901 1.819 1.819 0.000 ( +0.0% ) 29.09 29.54 -1.5% 1.869 1.941
TTbarMINIAOD14.0 2500.902 1.665 1.665 0.000 ( +0.0% ) 27.61 28.35 -2.6% 1.538 1.581
DYToLL_M-50_13TeV_pythia8 2500.911 14.345 14.345 0.000 ( +0.0% ) 8.24 8.11 +1.7% 1.055 1.097
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.912 0.171 0.240 -0.069 ( -28.9% ) 2.05 2.84 -27.6% 0.851 0.852
TTbar_Pow_LHE_13TeV 2500.913 0.110 0.110 0.000 ( +0.0% ) 2.57 2.62 -1.6% 0.853 0.855

cmsbuild avatar Jun 23 '25 15:06 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/45425

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File DataFormats/L1Scouting/interface/OrbitCollection.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes_def.xml modified in PR(s): #48093

cmsbuild avatar Jul 07 '25 11:07 cmsbuild

Pull request #48163 was updated.

cmsbuild avatar Jul 07 '25 11:07 cmsbuild

Hi @ftorrresd,

I saw https://github.com/cms-sw/cmssw/pull/48459 was merged. I didn't see any merge conflict, but I just rebased to the latest IB release anyway.

The workflow numbers for L1ScoutingNano are now 2500.2309. 2500.231. I checked the event content of the output root files from these workflows again and they look reasonable.

We discussed this PR in the L1Scouting meeting last week and other people from L1Scouting are reviewing this. Once the reviewers give a green light, I will change this PR to be ready for review so we can merge soon.

Best regards, Patin

patinkaew avatar Jul 07 '25 11:07 patinkaew

please test

ftorrresd avatar Jul 07 '25 12:07 ftorrresd

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/47111/summary.html COMMIT: a7823dc1deb5de1d89652878808aa5af2a7a1fc9 CMSSW: CMSSW_15_1_X_2025-07-07-1100/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48163/47111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4067201
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4067143
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 283 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 89100
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 89100
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.2309_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.2309_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.231_L1ScoutingSelectionNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.231_L1ScoutingSelectionNANOdata140Xrun3-size.json
workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.118 3.118 0.000 ( +0.0% ) 3.75 3.71 +1.0% 2.634 2.681
NANOmc106Xul17v2 2500.0002 3.177 3.177 0.000 ( +0.0% ) 3.46 3.44 +0.7% 2.645 3.123
NANOmc106Xul18v2 2500.0003 3.128 3.128 0.000 ( +0.0% ) 3.53 3.50 +0.9% 2.663 3.105
NANOdata106Xul16v2 2500.0101 1.560 1.560 0.000 ( +0.0% ) 6.02 5.89 +2.2% 2.358 2.673
NANOdata106Xul17v2 2500.0102 1.948 1.948 0.000 ( +0.0% ) 4.08 4.06 +0.5% 2.390 2.844
NANOdata106Xul18v2 2500.0103 1.914 1.914 0.000 ( +0.0% ) 4.88 4.86 +0.4% 2.440 2.778
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.67 1.70 -1.9% 2.615 2.609
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.55 1.22 +26.3% 2.599 2.606
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.49 1.54 -2.7% 2.556 2.567
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.22 1.26 -3.6% 2.764 2.764
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.28 1.33 -3.6% 2.677 2.688
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.46 1.39 +4.9% 2.616 2.620
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.24 1.20 +3.7% 2.724 2.722
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.04 0.87 +19.5% 2.725 2.704
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 4.28 4.26 +0.4% 2.442 3.061
NANOdata130Xrun3 2500.1101 1.799 1.799 0.000 ( +0.0% ) 6.17 6.28 -1.6% 2.669 2.689
ScoutingNANOdata130Xrun3 2500.1301 0.771 0.771 0.000 ( +0.0% ) 29.72 32.71 -9.1% 1.351 1.651
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 5.10 5.51 -7.5% 2.198 2.220
EGMNANOmc140X 2500.2202 3.876 3.876 0.000 ( +0.0% ) 3.68 3.91 -5.8% 2.424 2.501
BTVNANOmc140X 2500.2203 10.607 10.607 0.000 ( +0.0% ) 2.39 2.49 -3.9% 2.575 2.583
jmeNANOmc140X 2500.2204 6.666 6.666 0.000 ( +0.0% ) 1.10 1.12 -1.4% 2.419 2.418
lepTrackInfoNANOmc140X 2500.2206 3.570 3.570 0.000 ( +0.0% ) 3.68 3.92 -6.0% 2.363 2.371
ScoutingNANOmc140X 2500.2207 1.486 1.486 0.000 ( +0.0% ) 14.74 14.97 -1.5% 1.911 1.914
ScoutingNANOwithPromptmc140X 2500.2208 4.474 4.474 0.000 ( +0.0% ) 3.31 3.28 +0.9% 2.594 2.557
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 7.40 7.50 -1.3% 2.435 2.135
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.55 5.64 -1.6% 2.826 2.841
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.55 3.56 -0.3% 2.875 2.530
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.43 1.43 +0.0% 2.406 2.386
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.50 5.52 -0.4% 2.727 2.427
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 28.76 28.55 +0.7% 1.508 1.400
ScoutingNANOwithPromptdata140Xrun3 2500.2308 2.783 2.783 0.000 ( +0.0% ) 5.15 5.03 +2.3% 2.961 2.795
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 6.39 6.93 -7.8% 1.865 1.856
muDPGNANO140Xrun3 2500.2402 10.331 10.331 0.000 ( +0.0% ) 1.59 1.65 -3.6% 1.734 1.718
muDPGNANOBkg140Xrun3 2500.2403 2.712 2.712 0.000 ( +0.0% ) 15.61 15.50 +0.7% 1.041 1.011
hcalDPGNANO140Xrun3 2500.2404 486.016 486.016 0.000 ( +0.0% ) 1.10 1.12 -1.7% 1.632 1.643
hcalDPGCalibNANO140Xrun3 2500.2405 826.413 826.413 0.000 ( +0.0% ) 1.52 1.51 +0.7% 1.703 1.626
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.64 1.64 +0.5% 1.771 1.752
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.33 1.41 -6.1% 2.897 3.096
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.21 1.21 -0.7% 2.681 2.676
NANOmc150X 2500.3001 3.218 3.218 0.000 ( +0.0% ) 17.92 17.31 +3.6% 2.747 2.763
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 31.36 33.34 -5.9% 1.876 2.247
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 22.73 22.72 +0.0% 2.348 2.582
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 15.14 15.13 +0.0% 2.400 2.452
EGMNANOmc150X 2500.3202 4.110 4.110 0.000 ( +0.0% ) 13.93 13.62 +2.3% 2.466 2.525
BTVNANOmc150X 2500.3203 10.551 10.551 0.000 ( +0.0% ) 4.82 4.74 +1.6% 2.731 2.662
jmeNANOmc150X 2500.3204 6.760 6.760 0.000 ( +0.0% ) 1.36 1.32 +3.2% 2.651 2.679
jmeNANOrePuppimc150X 2500.3205 6.762 6.762 0.000 ( +0.0% ) 1.30 1.24 +4.4% 3.049 2.992
lepTrackInfoNANOmc150X 2500.3206 3.720 3.720 0.000 ( +0.0% ) 14.73 13.90 +6.0% 2.458 2.504
ScoutingNANOmc150X 2500.3207 1.562 1.562 0.000 ( +0.0% ) 19.22 18.74 +2.6% 2.449 2.448
ScoutingNANOwithPromptmc150X 2500.3208 4.773 4.773 0.000 ( +0.0% ) 10.69 10.41 +2.7% 2.816 2.790
BPHNANOmc150X 2500.3209 4.108 4.108 0.000 ( +0.0% ) 17.17 16.89 +1.7% 2.605 2.647
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 24.66 24.59 +0.3% 2.134 2.400
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 22.45 21.35 +5.1% 2.199 2.482
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.93 5.76 +2.9% 2.409 2.679
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.67 1.63 +2.4% 2.354 2.384
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.45 1.42 +1.8% 2.606 2.652
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 24.72 23.95 +3.2% 2.393 2.219
ScoutingNANOdata150Xrun3 2500.3307 1.737 1.737 0.000 ( +0.0% ) 29.64 30.64 -3.3% 1.510 1.684
ScoutingNANOwithPromptdata150Xrun3 2500.3308 2.601 2.601 0.000 ( +0.0% ) 17.63 17.13 +2.9% 2.575 2.572
BPHNANOdata150Xrun3 2500.3309 2.604 2.604 0.000 ( +0.0% ) 34.08 33.60 +1.4% 2.441 2.436
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 29.61 28.77 +2.9% 1.827 1.848
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 28.81 28.13 +2.4% 1.516 1.519
DYToLL_M-50_13TeV_pythia8 2500.9101 14.345 14.345 0.000 ( +0.0% ) 7.94 8.38 -5.3% 1.061 1.045
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.310 0.150 0.160 ( +106.7% ) 3.60 3.14 +14.8% 0.850 0.851
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.55 2.55 +0.2% 0.853 0.854

cmsbuild avatar Jul 07 '25 14:07 cmsbuild

I checked this PR. Please move it to "ready for review"

emeschi avatar Jul 15 '25 12:07 emeschi

@patinkaew ping!

emeschi avatar Jul 15 '25 15:07 emeschi

Dear @emeschi, Thank you for reviewing and pinging! This is now "ready for review".

patinkaew avatar Jul 15 '25 16:07 patinkaew

A new Pull Request was created by @patinkaew for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DataFormats/L1Scouting (daq)
  • DataFormats/NanoAOD (xpog)
  • L1TriggerScouting/Utilities (daq)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @Moanwar, @dickychant, @emeschi, @ftorrresd, @hqucms, @miquork, @smorovic, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @Mmiglio, @dinyar, @fabiocos, @gpetruc, @makortel, @missirol, @mmusich, @rovere, @slomeo this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild avatar Jul 15 '25 16:07 cmsbuild

+1 daq

emeschi avatar Jul 29 '25 14:07 emeschi

+1

emeschi avatar Jul 29 '25 14:07 emeschi

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48163/45651

  • Found files with invalid states:

    • DataFormats/L1Scouting/interface/OrbitFlatTable.h:
      • Added: dd9c7abcc727975caa74916a7335d05f98540b66
      • Modified: 023d5508c111bfe84e66133e7f6f568792958287
      • Deleted: 7fa4b88669b811f92b3df469ca0ab252db1685bd

  • There are other open Pull requests which might conflict with changes you have proposed:

    • File Configuration/PyReleaseValidation/python/relval_nano.py modified in PR(s): #48502, #48633
    • File DataFormats/L1Scouting/interface/OrbitCollection.h modified in PR(s): #48093
    • File DataFormats/L1Scouting/src/classes_def.xml modified in PR(s): #48093
    • File DataFormats/NanoAOD/interface/FlatTable.h modified in PR(s): #48633
    • File DataFormats/NanoAOD/src/classes_def.xml modified in PR(s): #48633
    • File PhysicsTools/NanoAOD/python/autoNANO.py modified in PR(s): #48502, #48633

cmsbuild avatar Jul 30 '25 10:07 cmsbuild

Pull request #48163 was updated. @AdrianoDee, @Moanwar, @cmsbuild, @dickychant, @emeschi, @ftorrresd, @hqucms, @miquork, @smorovic, @srimanob, @subirsarkar can you please check and sign again.

cmsbuild avatar Jul 30 '25 10:07 cmsbuild

Hi all,

As suggested by Matti, I moved OrbitFlatTable to DataFormats/NanoAOD.

I rerun tests and they all pass:

scram b runtests use-ibeos

Pass   95s ... CalibTracker/SiStripCommon/testCalibTrackerSiStripCommonAll
Pass  167s ... CalibTracker/SiStripCommon/testCalibTrackerSiStripCommonOneByOne
Pass   15s ... Configuration/Applications/TestConfigurationApplicationsConfigBuilder
Pass    2s ... Configuration/PyReleaseValidation/test-das-selected-lumis
Pass  368s ... Configuration/PyReleaseValidation/test-runTheMatrix-interactive
Pass  330s ... Configuration/PyReleaseValidation/test_MC_22_crosscheck
Pass  317s ... Configuration/PyReleaseValidation/test_MC_23_crosscheck

Pass   14s ... DataFormats/L1Scouting/TestL1ScoutingFormat

Pass   65s ... PhysicsTools/NanoAOD/test-btvNano-run
Pass    5s ... PhysicsTools/NanoAOD/test-btvNano-check
Pass    7s ... PhysicsTools/NanoAOD/testPhysicsToolsNanoAODTP

runTheMatrix.py -l 2500.2309,2500.2310 pass

patinkaew avatar Jul 30 '25 10:07 patinkaew

Hi @ftorrresd, Sorry for pinging you. Do you mind issue the test again?

patinkaew avatar Jul 31 '25 07:07 patinkaew

please test

iarspider avatar Jul 31 '25 08:07 iarspider

+1

Size: This PR adds an extra 24KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-43d56f/47469/summary.html COMMIT: 7fa4b88669b811f92b3df469ca0ab252db1685bd CMSSW: CMSSW_15_1_X_2025-07-30-2300/el8_amd64_gcc12 Additional Tests: NANO User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48163/47469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076122
  • DQMHistoTests: Total failures: 61
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076041
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 194 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 89100
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 89100
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 21 files compared)
  • Checked 134 log files, 80 edm output root files, 22 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

  • Nano ERROR: Missing ref/2500.2309_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.2309_L1ScoutingNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.231_L1ScoutingSelectionNANOdata140Xrun3-size.json
  • Nano ERROR: Missing ref/2500.231_L1ScoutingSelectionNANOdata140Xrun3-size.json
workflow id kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
NANOmc106Xul16v2 2500.0001 3.118 3.118 0.000 ( +0.0% ) 3.70 3.42 +8.3% 2.604 2.790
NANOmc106Xul17v2 2500.0002 3.177 3.177 0.000 ( +0.0% ) 3.44 3.21 +7.2% 2.632 3.281
NANOmc106Xul18v2 2500.0003 3.128 3.128 0.000 ( +0.0% ) 3.49 3.24 +8.0% 2.615 3.261
NANOdata106Xul16v2 2500.0101 1.560 1.560 0.000 ( +0.0% ) 5.97 5.62 +6.3% 2.351 2.855
NANOdata106Xul17v2 2500.0102 1.948 1.948 0.000 ( +0.0% ) 4.04 3.77 +7.3% 2.381 3.029
NANOdata106Xul18v2 2500.0103 1.914 1.914 0.000 ( +0.0% ) 4.83 4.55 +6.3% 2.411 3.004
NANOmcUL16APVreMINI 2500.0201 0.022 0.022 0.000 ( +0.0% ) 1.66 1.78 -6.6% 2.607 2.996
NANOmcUL16reMINI 2500.0202 0.022 0.022 0.000 ( +0.0% ) 1.59 1.62 -2.4% 2.595 2.978
NANOmcUL17reMINI 2500.0203 0.022 0.022 0.000 ( +0.0% ) 1.52 1.55 -1.7% 2.557 2.695
NANOmcUL18reMINI 2500.0204 0.022 0.022 0.000 ( +0.0% ) 1.29 1.35 -4.5% 2.760 3.130
NANOdataUL16APVreMINI 2500.0301 0.035 0.035 0.000 ( +0.0% ) 1.29 1.39 -7.0% 2.677 2.926
NANOdataUL16reMINI 2500.0302 0.036 0.036 0.000 ( +0.0% ) 1.46 1.52 -3.6% 2.624 2.941
NANOdataUL17reMINI 2500.0303 0.037 0.037 0.000 ( +0.0% ) 1.24 1.33 -7.0% 2.716 2.956
NANOdataUL18reMINI 2500.0304 0.036 0.036 0.000 ( +0.0% ) 1.27 1.34 -5.2% 2.701 2.933
NANOmc130X 2500.1001 3.220 3.220 0.000 ( +0.0% ) 4.24 3.89 +9.2% 2.454 3.232
NANOdata130Xrun3 2500.1101 1.799 1.799 0.000 ( +0.0% ) 6.22 5.80 +7.4% 2.637 2.823
ScoutingNANOdata130Xrun3 2500.1301 0.771 0.771 0.000 ( +0.0% ) 32.83 33.38 -1.7% 1.683 1.696
muPOGNANOmc140X 2500.2201 2.065 2.065 0.000 ( +0.0% ) 5.31 5.56 -4.5% 2.179 2.356
EGMNANOmc140X 2500.2202 3.876 3.876 0.000 ( +0.0% ) 3.82 4.00 -4.4% 2.473 2.726
BTVNANOmc140X 2500.2203 10.607 10.607 0.000 ( +0.0% ) 2.43 2.45 -0.6% 2.641 2.934
jmeNANOmc140X 2500.2204 6.666 6.666 0.000 ( +0.0% ) 1.11 1.10 +1.1% 2.543 2.715
lepTrackInfoNANOmc140X 2500.2206 3.570 3.570 0.000 ( +0.0% ) 3.83 4.00 -4.3% 2.448 2.717
ScoutingNANOmc140X 2500.2207 1.486 1.486 0.000 ( +0.0% ) 15.18 15.10 +0.5% 1.965 2.024
ScoutingNANOwithPromptmc140X 2500.2208 4.474 4.474 0.000 ( +0.0% ) 3.26 3.05 +7.0% 2.770 2.935
muPOGNANO140Xrun3 2500.2301 1.469 1.469 0.000 ( +0.0% ) 7.32 7.58 -3.5% 2.410 2.676
EGMNANOdata140Xrun3 2500.2302 2.623 2.623 0.000 ( +0.0% ) 5.50 5.38 +2.3% 2.740 3.021
BTVNANOdata140Xrun3 2500.2303 5.612 5.612 0.000 ( +0.0% ) 3.50 3.42 +2.4% 2.881 2.860
jmeNANOdata140Xrun3 2500.2304 3.976 3.976 0.000 ( +0.0% ) 1.41 1.34 +5.6% 2.754 2.713
lepTrackInfoNANOdata140Xrun3 2500.2306 2.413 2.413 0.000 ( +0.0% ) 5.48 5.33 +2.9% 2.707 2.652
ScoutingNANOdata140Xrun3 2500.2307 1.101 1.101 0.000 ( +0.0% ) 28.58 27.66 +3.3% 1.507 1.633
ScoutingNANOwithPromptdata140Xrun3 2500.2308 2.783 2.783 0.000 ( +0.0% ) 4.93 4.52 +9.1% 2.933 3.150
l1DPGNANO140Xrun3 2500.2401 9.404 9.404 0.000 ( +0.0% ) 7.17 6.49 +10.4% 1.834 1.935
muDPGNANO140Xrun3 2500.2402 10.331 10.331 0.000 ( +0.0% ) 1.65 1.58 +4.8% 1.681 1.735
muDPGNANOBkg140Xrun3 2500.2403 2.712 2.712 0.000 ( +0.0% ) 15.69 14.98 +4.8% 1.065 1.066
hcalDPGNANO140Xrun3 2500.2404 486.016 486.016 0.000 ( +0.0% ) 1.13 1.10 +3.3% 1.621 1.737
hcalDPGCalibNANO140Xrun3 2500.2405 826.413 826.413 0.000 ( +0.0% ) 1.52 1.46 +3.9% 1.639 1.707
hcalDPGMCNANO140Xrun3 2500.2501 645.333 645.333 0.000 ( +0.0% ) 1.65 1.60 +3.5% 1.705 1.814
NANOmc2024reMINI 2500.2601 0.021 0.021 0.000 ( +0.0% ) 1.45 1.42 +1.8% 2.824 3.155
NANOdata2024reMINI 2500.2701 0.036 0.036 0.000 ( +0.0% ) 1.26 1.26 +0.0% 2.662 2.927
NANOmc150X 2500.3001 3.217 3.217 0.000 ( +0.0% ) 17.28 14.69 +17.7% 2.676 2.770
NANOdata150X 2500.3101 2.144 2.144 0.000 ( +0.0% ) 33.08 28.42 +16.4% 2.247 2.494
NANOdata150X 2500.3102 2.630 2.630 0.000 ( +0.0% ) 22.93 18.00 +27.4% 2.328 2.570
muPOGNANOmc150X 2500.3201 2.255 2.255 0.000 ( +0.0% ) 14.50 11.34 +27.8% 2.394 2.643
EGMNANOmc150X 2500.3202 4.111 4.111 0.000 ( +0.0% ) 13.47 10.82 +24.5% 2.464 2.751
BTVNANOmc150X 2500.3203 10.552 10.552 0.000 ( +0.0% ) 4.60 4.07 +12.9% 2.736 2.972
jmeNANOmc150X 2500.3204 6.760 6.760 0.000 ( +0.0% ) 1.30 1.18 +9.6% 2.649 2.351
jmeNANOrePuppimc150X 2500.3205 6.763 6.763 0.000 ( +0.0% ) 1.24 1.13 +9.5% 3.180 2.608
lepTrackInfoNANOmc150X 2500.3206 3.721 3.721 0.000 ( +0.0% ) 14.24 12.27 +16.1% 2.510 2.738
ScoutingNANOmc150X 2500.3207 1.562 1.562 0.000 ( +0.0% ) 18.72 16.79 +11.5% 2.447 2.551
ScoutingNANOwithPromptmc150X 2500.3208 4.774 4.774 0.000 ( +0.0% ) 10.34 9.83 +5.1% 2.802 2.985
BPHNANOmc150X 2500.3209 4.109 4.109 0.000 ( +0.0% ) 16.33 15.32 +6.6% 2.610 2.813
muPOGNANO150Xrun3 2500.3301 1.125 1.125 0.000 ( +0.0% ) 23.20 21.19 +9.5% 2.108 2.402
EGMNANOdata150Xrun3 2500.3302 2.985 2.985 0.000 ( +0.0% ) 20.92 18.68 +12.0% 2.185 2.495
BTVNANOdata150Xrun3 2500.3303 7.971 7.971 0.000 ( +0.0% ) 5.64 4.87 +15.7% 2.363 2.705
jmeNANOdata150Xrun3 2500.3304 4.349 4.349 0.000 ( +0.0% ) 1.58 1.47 +7.8% 2.357 2.649
jmeNANOrePuppidata150Xrun3 2500.3305 4.332 4.332 0.000 ( +0.0% ) 1.38 1.32 +5.1% 2.613 2.926
lepTrackInfoNANOdata150Xrun3 2500.3306 2.625 2.625 0.000 ( +0.0% ) 22.84 18.25 +25.1% 2.158 2.488
ScoutingNANOdata150Xrun3 2500.3307 1.737 1.737 0.000 ( +0.0% ) 30.16 28.14 +7.2% 1.513 1.694
ScoutingNANOwithPromptdata150Xrun3 2500.3308 2.601 2.601 0.000 ( +0.0% ) 17.09 16.47 +3.8% 2.525 2.799
BPHNANOdata150Xrun3 2500.3309 2.604 2.604 0.000 ( +0.0% ) 32.76 31.27 +4.8% 2.366 2.536
TTbarMINIAOD10.6_UL18v2 2500.9001 1.819 1.819 0.000 ( +0.0% ) 28.67 27.60 +3.9% 1.838 1.939
TTbarMINIAOD14.0 2500.9002 1.665 1.665 0.000 ( +0.0% ) 27.54 27.74 -0.7% 1.551 1.579
DYToLL_M-50_13TeV_pythia8 2500.9101 14.345 14.345 0.000 ( +0.0% ) 7.62 7.37 +3.4% 1.101 1.097
DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV 2500.9102 0.437 0.240 0.197 ( +81.9% ) 2.94 2.92 +0.6% 0.851 0.853
TTbar_Pow_LHE_13TeV 2500.9103 0.110 0.110 0.000 ( +0.0% ) 2.49 2.43 +2.7% 0.855 0.853

cmsbuild avatar Jul 31 '25 10:07 cmsbuild

Hi @AdrianoDee, @Moanwar, @cmsbuild, @DickyChant, @emeschi, @ftorrresd, @hqucms, @miquork, @smorovic, @srimanob, @subirsarkar

Are you able to review and/or sign please?

Thanks a lot!

Thomas

tj710 avatar Aug 04 '25 12:08 tj710

+1

ftorrresd avatar Aug 04 '25 13:08 ftorrresd

+Upgrade

Moanwar avatar Aug 04 '25 14:08 Moanwar