cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard
verified publisher icon cms-sw

[DRAFT] minimum changes to produce wf diffs seen in PR#47966

Open mroguljic opened this issue 7 months ago • 13 comments

PR#47966 shows unexpected widely distributed small differences in test workflows. The minimal changes in this draft produce the same number of differences on a single workflow, 140.045, as the PR. This draft is created to allow the cms bot to run tests to check if the same happens in other workflows.

mroguljic avatar May 22 '25 10:05 mroguljic

cms-bot internal usage

cmsbuild avatar May 22 '25 10:05 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/44916

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File CondFormats/SiPixelTransient/interface/SiPixelTemplate.h modified in PR(s): #47966
    • File CondFormats/SiPixelTransient/src/SiPixelTemplate.cc modified in PR(s): #47966

cmsbuild avatar May 22 '25 10:05 cmsbuild

@cmsbuild, please test

mmusich avatar May 22 '25 11:05 mmusich

allow @mroguljic test rights

fwyzard avatar May 22 '25 11:05 fwyzard

+1

Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/46322/summary.html COMMIT: a031f18f74cae1d1718dc36ad1add287b9b83a8d CMSSW: CMSSW_15_1_X_2025-05-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48146/46322/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar May 22 '25 13:05 cmsbuild

Per cmsbot, this accounts for roughly half the differences observed in the main PR. I've ran valgrind on one event in step 3 of 140.045 in two environments: reference (with no changes to cmssw) and reference + this PR. The two outputs can be found on lxplus at these locations: reference, PR

mroguljic avatar May 28 '25 07:05 mroguljic

please test (Since the old ones already disappeared)

perrotta avatar Jun 20 '25 07:06 perrotta

+1

Size: This PR adds an extra 16KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/46847/summary.html COMMIT: a031f18f74cae1d1718dc36ad1add287b9b83a8d CMSSW: CMSSW_15_1_X_2025-06-19-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48146/46847/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Jun 20 '25 10:06 cmsbuild

This PR contains too many commits (355 >= 240) and will not be processed. Please ensure you have selected the correct target branch and consider squashing unnecessary commits. The processing of this PR will resume once the commit count drops below the limit.

cmsbuild avatar Jun 20 '25 14:06 cmsbuild

please test

mroguljic avatar Jun 20 '25 14:06 mroguljic

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45267

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File CondFormats/SiPixelTransient/interface/SiPixelTemplate.h modified in PR(s): #48356
    • File CondFormats/SiPixelTransient/src/SiPixelTemplate.cc modified in PR(s): #48263, #48356

cmsbuild avatar Jun 20 '25 14:06 cmsbuild

Pull request #48146 was updated.

cmsbuild avatar Jun 20 '25 14:06 cmsbuild

+1

Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/46854/summary.html COMMIT: b748d948658147a29c87315d596de28657aa6a69 CMSSW: CMSSW_15_1_X_2025-06-20-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48146/46854/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4058157
  • DQMHistoTests: Total failures: 43
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4058094
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jun 20 '25 17:06 cmsbuild

please test

mroguljic avatar Jul 04 '25 21:07 mroguljic

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45411

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File CondFormats/SiPixelTransient/src/SiPixelTemplate.cc modified in PR(s): #48263

Code check has found code style and quality issues which could be resolved by applying following patch(s)

  • code-format: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45411/code-format.patch e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45411/code-format.patch | patch -p1 You can also run scram build code-format to apply code format directly

cmsbuild avatar Jul 04 '25 21:07 cmsbuild

^ testing to check the number of diffs when we have the assert, but with an explicit initializazion and (dummy) call to ygx0_ members ygsig. They are unused and uninitialized when goodEdgeAlgo is false.

mroguljic avatar Jul 04 '25 21:07 mroguljic

-code-checks

@mroguljic it won't be possible to test until the code-checks issue is resolved.

mmusich avatar Jul 05 '25 09:07 mmusich

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45412

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File CondFormats/SiPixelTransient/src/SiPixelTemplate.cc modified in PR(s): #48263

cmsbuild avatar Jul 05 '25 10:07 cmsbuild

Pull request #48146 was updated.

cmsbuild avatar Jul 05 '25 11:07 cmsbuild

please test

mroguljic avatar Jul 05 '25 11:07 mroguljic

+1

Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/47092/summary.html COMMIT: 6e7c1e17b02df8eb81817ce6fab4052a9c368c9f CMSSW: CMSSW_15_1_X_2025-07-04-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48146/47092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Jul 05 '25 14:07 cmsbuild

please test

mroguljic avatar Jul 05 '25 16:07 mroguljic

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45416

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File CondFormats/SiPixelTransient/src/SiPixelTemplate.cc modified in PR(s): #48263

cmsbuild avatar Jul 06 '25 08:07 cmsbuild

Pull request #48146 was updated.

cmsbuild avatar Jul 06 '25 08:07 cmsbuild

+1

Size: This PR adds an extra 44KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/47095/summary.html COMMIT: 24ff64adaeac9c21781d13eda7c73354cd3b9b2b CMSSW: CMSSW_15_1_X_2025-07-06-0000/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48146/47095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild avatar Jul 06 '25 12:07 cmsbuild

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48146/45419

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File RecoLocalTracker/SiPixelRecHits/src/SiPixelTemplateReco.cc modified in PR(s): #48263

cmsbuild avatar Jul 07 '25 08:07 cmsbuild

Pull request #48146 was updated.

cmsbuild avatar Jul 07 '25 08:07 cmsbuild

please test

mroguljic avatar Jul 07 '25 08:07 mroguljic

^ testing to see if declaration of variables at initialization will stabilize the output (as suggested here)

mroguljic avatar Jul 07 '25 08:07 mroguljic

+1

Size: This PR adds an extra 32KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32fe96/47101/summary.html COMMIT: f09e69d8aacad7e63acbc22a342ccfca959d9624 CMSSW: CMSSW_15_1_X_2025-07-06-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48146/47101/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4067201
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4067170
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Jul 07 '25 10:07 cmsbuild