cms-sw
Add PbPbHighPtJets skim for 2024 PbPb
PR description:
This PR adds a new skim for high-pT jets (pT > 300, |eta| < 2.4) saving RAW-RECO in PbPb. Should correspond to no greater than 100k events (estimate from 2018 data puts it at ~20k). To be applied to the hadronic physics PDs (i.e. not HIForward/UPCs).
@mandrenguyen
PR validation:
Tested in CMSSW_14_2_X_2024-10-20-0000, compiles and appears to run when tested w/ runTheMatrix.py -l 142.0 -n -e, modifying step 3 to include the newly defined PbPbHighPtJets skim as:
-s RAW2DIGI,L1Reco,RECO,SKIM:PbPbHighPtJets,PAT
The output appears correctly sensitive to specified trigger path and threshold cuts.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 14_1_X
youyingli This is the last PR needed for PbPb data taking this year (well, it's backport). As you suggested let's follow up with @cms-sw/pdmv-l2 how to do test these.
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46499/42350
- There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Skimming/python/Skims_PbPb_cff.py modified in PR(s): #46434
A new Pull Request was created by @cfmcginn for master.
It involves the following packages:
- Configuration/Skimming (pdmv)
@AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please review it and eventually sign? Thanks. @Martin-Grunewald, @fabiocos, @missirol, @youyingli this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42382/summary.html
COMMIT: 3258df0e5ded43c87af6520e50da254a7b432d9f
CMSSW: CMSSW_14_2_X_2024-10-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46499/42382/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 4 lines to the logs
- Reco comparison results: 11 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3566343
- DQMHistoTests: Total failures: 425
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3565898
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 201 log files, 171 edm output root files, 46 DQM output files
- TriggerResults: no differences found
Should this skim be also included in the autoSkim file?
Yes, it should be added. However, #46447 also modified this line which could conflict.
I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after https://github.com/cms-sw/cmssw/pull/46447 is merged?
I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after #46447 is merged?
I think it's best to just update everything now, and we handle the merge conflicts as they arise.
I will setup the backport. For the autoSkim line, perhaps it makes sense for me to update after #46447 is merged?
I think it's best to just update everything now, and we handle the merge conflicts as they arise.
Understood, will do
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46499/42364
- There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Skimming/python/Skims_PbPb_cff.py modified in PR(s): #46434
- File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46434, #46447
Pull request #46499 was updated. @AdrianoDee, @cmsbuild, @kskovpen, @miquork, @sunilUIET can you please check and sign again.
Backport to 14_1_X created; PR here: https://github.com/cms-sw/cmssw/pull/46514 (also edited initial message with this info)
+1
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42404/summary.html
COMMIT: bc10da27894cd7037cc594d0d8e5ccbcd9c9b961
CMSSW: CMSSW_14_2_X_2024-10-27-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46499/42404/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 3 lines to the logs
- Reco comparison results: 10 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3569177
- DQMHistoTests: Total failures: 441
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3568716
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 201 log files, 171 edm output root files, 46 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
@cfmcginn , this PR now has conflicts, can you please resolve it?
I believe the conflict is resolved
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46499/42443
- There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Skimming/python/autoSkim.py modified in PR(s): #46447
Pull request #46499 was updated. @cmsbuild can you please check and sign again.
-1
Failed Tests: RelVals-INPUT
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/summary.html
COMMIT: b88005619bcf6aa08dfb058b79bbe7c90ca2cda9
CMSSW: CMSSW_14_2_X_2024-10-30-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46499/42490/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @mmusich cms-sw/cmssw#46530
- @24LopezR cms-sw/cmssw#46529
- @smuzaffar cms-sw/cmssw#46442
- @DebabrataBhowmik cms-sw/cmssw#46540
- @JHiltbrand cms-sw/cmssw#46538
- @stahlleiton cms-sw/cmssw#46434
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3655e/42490/git-merge-result
- DAS Queries: The DAS query tests failed, see the summary page for details.
RelVals-INPUT
- 2024.000001
2024.000001_RunJetMET02024D_10k/step1_dasquery.log - 2024.001001
2024.001001_RunZeroBias2024D_10k/step1_dasquery.log - 2024.100001
2024.100001_RunJetMET02024C_10k/step1_dasquery.log
Expand to see more relval errors ...
- 2024.101001
- 2024.000001
- 2024.001001
- 2024.100001
- 2024.101001
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 1883 differences found in the comparisons
- DQMHistoTests: Total files compared: 46
- DQMHistoTests: Total histograms compared: 3569372
- DQMHistoTests: Total failures: 225
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3569127
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
- Checked 201 log files, 171 edm output root files, 46 DQM output files
- TriggerResults: no differences found