cms-sw
[HGCAL trigger] Fix rounding in floating point compression
Should fix #46474 :
- Fix rounding in HGCAL frontend floating point compression.
- Rounding should not be applied if
exponent==1
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46491/42346
- There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/L1THGCal/src/HGCalVFECompressionImpl.cc modified in PR(s): #46411
A new Pull Request was created by @jbsauvan for master.
It involves the following packages:
- L1Trigger/L1THGCal (l1, upgrade)
@Moanwar, @aloeliger, @cmsbuild, @epalencia, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks. @Martin-Grunewald, @amarini, @lgray, @missirol, @mmusich this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a7fd/42358/summary.html
COMMIT: a151aa811ce49db048b24892fb1302f710d82b9a
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46491/42358/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @SanghyunKo cms-sw/cmssw#46423
- @tomalin cms-sw/cmssw#46241
- @trackreco cms-sw/cmssw#46324
- @JunseokLee3609 cms-sw/cmssw#46462
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a7fd/42358/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a7fd/42358/git-merge-result
+1
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a7fd/42357/summary.html
COMMIT: a151aa811ce49db048b24892fb1302f710d82b9a
CMSSW: CMSSW_14_2_X_2024-10-23-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46491/42357/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- You potentially added 1 lines to the logs
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 47
- DQMHistoTests: Total histograms compared: 3665145
- DQMHistoTests: Total failures: 458
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3664667
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
- Checked 206 log files, 175 edm output root files, 47 DQM output files
- TriggerResults: no differences found
@smuzaffar I don't really know what I'm looking for here, is this PR sufficient to fix this issue?
@aloeliger , this PR does fix the issue https://github.com/cms-sw/cmssw/issues/46474 as it avoids calling
const bool roundup = ((shifted_value >> (exponent - 2)) & 1ULL) == 1ULL;
code for exponent=1. https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52a7fd/42358/runTheMatrix-results/23634.0_TTbar_14TeV+2026D95/step2_TTbar_14TeV+2026D95.log confirms that the runtime error HGCalVFECompressionImpl.cc:53:42: runtime error: shift exponent 4294967295 is too large for 64-bit type is not there any more
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
