cmssw icon indicating copy to clipboard operation
cmssw copied to clipboard

[14_1] Remove unused L1TCaloSummary DQM sequences causing issues with HCAL.

Open aloeliger opened this issue 1 year ago • 3 comments

Backport of https://github.com/cms-sw/cmssw/pull/46482

PR description:

Taken from original:

This PR removes two unused sequences in the CICADA DQM that were potentially causing duplicate TPs seen in HCAL tests. No DQM changes are expected as a result of this change.

Also changes Calo Summary DQM configuration to use GT digis instead of test crate digis, which is more correct.

PR validation:

Sequence has been confirmed to work in failing workflows without crashing. HCAL reports this fixes the issue.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This backport is required for eventual backport to 14_0 for MC production with corrected DQM.

aloeliger avatar Oct 23 '24 09:10 aloeliger

A new Pull Request was created by @aloeliger for CMSSW_14_1_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. @missirol, @mmusich this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

  • Backported from #46482

cmsbuild avatar Oct 23 '24 09:10 cmsbuild

cms-bot internal usage

cmsbuild avatar Oct 23 '24 09:10 cmsbuild

Pull request #46487 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 23 '24 10:10 cmsbuild

Pull request #46487 was updated. @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

cmsbuild avatar Oct 24 '24 08:10 cmsbuild

please test

aloeliger avatar Oct 24 '24 08:10 aloeliger

+1

Size: This PR adds an extra 28KB to repository Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d11b1/42366/summary.html COMMIT: 27853c14c4602df6317865844c739eaeb1760866 CMSSW: CMSSW_14_1_X_2024-10-23-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46487/42366/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3562835
  • DQMHistoTests: Total failures: 364
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3562451
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

cmsbuild avatar Oct 24 '24 12:10 cmsbuild

+dqm

antoniovagnerini avatar Oct 25 '24 10:10 antoniovagnerini

+l1

aloeliger avatar Oct 25 '24 10:10 aloeliger

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild avatar Oct 25 '24 10:10 cmsbuild

+1

mandrenguyen avatar Oct 28 '24 13:10 mandrenguyen