cms-sw
Fix for nalphabits == 0
PR description:
This PR fixes the runtime error seen in recent UBSAN IBs that was reported in #46403.
The fix is to add a short circuit to the offending conditional, so that when nalphabits is zero, the negative bit shift is never evaluated. This has no effect on the end results because newalpha is never used when nalphabits is zero.
Fixes #46403
PR validation:
I was able to reproduce the runtime error reported in #46403 within the 23634.0 workflow, and after adding this short circuit, the same workflow gives no error.
@tomalin
+code-checks
Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46481/42336
A new Pull Request was created by @aehart for master.
It involves the following packages:
- L1Trigger/TrackFindingTracklet (l1)
@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks. @Martin-Grunewald, @erikbutz, @missirol, @mmusich, @skinnari this is something you requested to watch as well. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here
+1
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f04e0/42345/summary.html
COMMIT: 702ab371d67f2d14214f7a5df2780ec3f49f454d
CMSSW: CMSSW_14_2_UBSAN_X_2024-10-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46481/42345/install.sh to create a dev area with all the needed externals and cmssw changes.
The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
- @SanghyunKo cms-sw/cmssw#46423
- @tomalin cms-sw/cmssw#46241
- @trackreco cms-sw/cmssw#46324
- @JunseokLee3609 cms-sw/cmssw#46462
You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f04e0/42345/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f04e0/42345/git-merge-result
+1
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4f04e0/42348/summary.html
COMMIT: 702ab371d67f2d14214f7a5df2780ec3f49f454d
CMSSW: CMSSW_14_2_X_2024-10-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46481/42348/install.sh to create a dev area with all the needed externals and cmssw changes.
Comparison Summary
Summary:
- No significant changes to the logs found
- Reco comparison results: 8 differences found in the comparisons
- DQMHistoTests: Total files compared: 47
- DQMHistoTests: Total histograms compared: 3665145
- DQMHistoTests: Total failures: 505
- DQMHistoTests: Total nulls: 0
- DQMHistoTests: Total successes: 3664620
- DQMHistoTests: Total skipped: 20
- DQMHistoTests: Total Missing objects: 0
- DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
- Checked 206 log files, 175 edm output root files, 47 DQM output files
- TriggerResults: no differences found
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)
